opendev/gerrit
Code Issues Proposed changes

init: Guess JDBC driver class if not configured

Browse Source 
If the JDBC URL points to one of the 3 standard supported database
types, guess the Driver class name automatically. This fixes up any
old installations that are missing the driver class.

Bug: issue 1870
Change-Id: I897ab3a16cf91766a848980302182ab1070f65cb
This commit is contained in:
Shawn Pearce
2013-04-26 08:11:16 -07:00
parent 64109d1976
commit 2e45ff02d4
1 changed files with 21 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/JDBCInitializer.java
View File

@@ -16,13 +16,28 @@ package com.google.gerrit.pgm.init;
import static com.google.gerrit.pgm.init.InitUtil.username; import static com.google.gerrit.pgm.init.InitUtil.username;
class JDBCInitializer implements DatabaseConfigInitializer { import com.google.common.base.Strings;
class JDBCInitializer implements DatabaseConfigInitializer {
@Override @Override
public void initConfig(Section databaseSection) { public void initConfig(Section database) {
databaseSection.string("Driver class name", "driver", null); database.string("URL", "url", null);
databaseSection.string("URL", "url", null); guessDriver(database);
databaseSection.string("Database username", "username", username()); database.string("Driver class name", "driver", null);
databaseSection.password("username", "password"); database.string("Database username", "username", username());
database.password("username", "password");
}
private void guessDriver(Section database) {
String url = Strings.emptyToNull(database.get("url"));
if (url != null && Strings.isNullOrEmpty(database.get("driver"))) {
if (url.startsWith("jdbc:h2:")) {
database.set("driver", "org.h2.Driver");
} else if (url.startsWith("jdbc:mysql:")) {
database.set("driver", "com.mysql.jdbc.Driver");
} else if (url.startsWith("jdbc:postgresql:")) {
database.set("driver", "org.postgresql.Driver");
}
}
} }
} }