opendev/gerrit
Code Issues Proposed changes

Merge "Fix keyLocation computation on ranged comments"

Browse Source
This commit is contained in:
Tao Zhou
2019-10-21 12:26:32 +00:00
committed by Gerrit Code Review
parent 00800f7493 b97225c5e4
commit 2e497a2e2e
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
polygerrit-ui/app/elements/diff/gr-diff/gr-diff.js
View File

@@ -400,7 +400,13 @@
const commentSide = threadEl.getAttribute('comment-side'); const commentSide = threadEl.getAttribute('comment-side');
const lineNum = Number(threadEl.getAttribute('line-num')) || const lineNum = Number(threadEl.getAttribute('line-num')) ||
GrDiffLine.FILE; GrDiffLine.FILE;
const commentRange = threadEl.range || {};
keyLocations[commentSide][lineNum] = true; keyLocations[commentSide][lineNum] = true;
// Add start_line as well if exists,
// the being and end of the range should not be collapsed.
if (commentRange.start_line) {
keyLocations[commentSide][commentRange.start_line] = true;
}
} }
return keyLocations; return keyLocations;
}, },