opendev/gerrit
Code Issues Proposed changes

Hide quick approve button for draft changes

Browse Source 
A draft change cannot be submitted, hence quick approving it is not
that important. Hiding the quick approve button on draft changes makes
space in the header for displaying more important actions such as
'Publish' (done in a follow-up change).

Change-Id: I3319cd7b7e63577d1cdc4c6dce3e888672bd5f29
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2015-01-07 13:35:51 +01:00
committed by David Pursehouse
parent 6374815b60
commit 2e7130c4f3
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/QuickApprove.java
View File

@@ -46,7 +46,7 @@ class QuickApprove extends Button implements ClickHandler {
setVisible(false);
return;
}
if (info.revision(commit).is_edit()) {
if (info.revision(commit).is_edit() || info.revision(commit).draft()) {
setVisible(false);
return;
}