diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/GitModules.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/GitModules.java index 0e954f3f25..26c59c221f 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/GitModules.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/GitModules.java @@ -67,7 +67,7 @@ public class GitModules { logDebug("Loading .gitmodules of {} for project {}", branch, project); OpenRepo or; try { - or = orm.openRepo(project, false); + or = orm.openRepo(project); } catch (NoSuchProjectException e) { throw new IOException(e); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java index 9d62721d41..9d4c8119c7 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java @@ -727,7 +727,7 @@ public class MergeOp implements AutoCloseable { throws IntegrationException { for (Project.NameKey project : projects) { try { - orm.openRepo(project, true); + orm.openRepo(project); } catch (NoSuchProjectException noProject) { logWarn("Project " + noProject.project() + " no longer exists, " + "abandoning open changes"); diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOpRepoManager.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOpRepoManager.java index fb4c2d434b..cd76aff61e 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOpRepoManager.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOpRepoManager.java @@ -187,13 +187,8 @@ public class MergeOpRepoManager implements AutoCloseable { return or; } - public OpenRepo openRepo(Project.NameKey project, boolean abortIfOpen) + public OpenRepo openRepo(Project.NameKey project) throws NoSuchProjectException, IOException { - if (abortIfOpen) { - checkState(!openRepos.containsKey(project), - "repo already opened: %s", project); - } - if (openRepos.containsKey(project)) { return openRepos.get(project); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/SubmoduleOp.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/SubmoduleOp.java index 01d73ece47..8e84ffb73a 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/SubmoduleOp.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/SubmoduleOp.java @@ -251,7 +251,7 @@ public class SubmoduleOp { } OpenRepo or; try { - or = orm.openRepo(s.getProject(), false); + or = orm.openRepo(s.getProject()); } catch (NoSuchProjectException e) { // A project listed a non existent project to be allowed // to subscribe to it. Allow this for now, i.e. no exception is @@ -290,7 +290,7 @@ public class SubmoduleOp { for (Branch.NameKey targetBranch : branches) { Project.NameKey targetProject = targetBranch.getParentKey(); try { - OpenRepo or = orm.openRepo(targetProject, false); + OpenRepo or = orm.openRepo(targetProject); ObjectId id = or.repo.resolve(targetBranch.get()); if (id == null) { logDebug("The branch " + targetBranch + " doesn't exist."); @@ -327,7 +327,7 @@ public class SubmoduleOp { if (dst.containsKey(project)) { superProjects.add(project); // get a new BatchUpdate for the super project - OpenRepo or = orm.openRepo(project, false); + OpenRepo or = orm.openRepo(project); for (Branch.NameKey branch : dst.get(project)) { addOp(or.getUpdate(), branch); } @@ -348,7 +348,7 @@ public class SubmoduleOp { throws IOException, SubmoduleException { OpenRepo or; try { - or = orm.openRepo(subscriber.getParentKey(), false); + or = orm.openRepo(subscriber.getParentKey()); } catch (NoSuchProjectException | IOException e) { throw new SubmoduleException("Cannot access superproject", e); } @@ -404,7 +404,7 @@ public class SubmoduleOp { throws IOException, SubmoduleException { OpenRepo or; try { - or = orm.openRepo(subscriber.getParentKey(), false); + or = orm.openRepo(subscriber.getParentKey()); } catch (NoSuchProjectException | IOException e) { throw new SubmoduleException("Cannot access superproject", e); } @@ -444,7 +444,7 @@ public class SubmoduleOp { throws SubmoduleException, IOException { OpenRepo subOr; try { - subOr = orm.openRepo(s.getSubmodule().getParentKey(), false); + subOr = orm.openRepo(s.getSubmodule().getParentKey()); } catch (NoSuchProjectException | IOException e) { throw new SubmoduleException("Cannot access submodule", e); }