opendev/gerrit
Code Issues Proposed changes

DefaultRefFilter: Avoid Repository#getAllRefs

Browse Source 
Change-Id: I4817ffd75e7d3ec05ced085f10c0d4ef8f8816b2
This commit is contained in:
Dave Borowitz
2019-01-04 16:08:04 -08:00
parent 72458dca53
commit 2e9cfd0ce6
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
java/com/google/gerrit/server/permissions/DefaultRefFilter.java
View File

@@ -20,6 +20,7 @@ import static com.google.gerrit.reviewdb.client.RefNames.REFS_CHANGES;
import static com.google.gerrit.reviewdb.client.RefNames.REFS_CONFIG; import static com.google.gerrit.reviewdb.client.RefNames.REFS_CONFIG;
import static com.google.gerrit.reviewdb.client.RefNames.REFS_USERS_SELF; import static com.google.gerrit.reviewdb.client.RefNames.REFS_USERS_SELF;
import static java.util.Objects.requireNonNull; import static java.util.Objects.requireNonNull;
import static java.util.stream.Collectors.toMap;
import com.google.common.collect.ImmutableSet; import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Maps; import com.google.common.collect.Maps;
@@ -248,7 +249,7 @@ class DefaultRefFilter {
repo, repo,
opts.filterTagsSeparately() opts.filterTagsSeparately()
? filter( ? filter(
repo.getAllRefs(), getAllRefsMap(repo),
repo, repo,
opts.toBuilder().setFilterTagsSeparately(false).build()) opts.toBuilder().setFilterTagsSeparately(false).build())
.values() .values()
@@ -263,6 +264,14 @@ class DefaultRefFilter {
return result; return result;
} }
private static Map<String, Ref> getAllRefsMap(Repository repo) throws PermissionBackendException {
try {
return repo.getRefDatabase().getRefs().stream().collect(toMap(Ref::getName, r -> r));
} catch (IOException e) {
throw new PermissionBackendException(e);
}
}
private Map<String, Ref> fastHideRefsMetaConfig(Map<String, Ref> refs) private Map<String, Ref> fastHideRefsMetaConfig(Map<String, Ref> refs)
throws PermissionBackendException { throws PermissionBackendException {
if (refs.containsKey(REFS_CONFIG) && !canReadRef(REFS_CONFIG)) { if (refs.containsKey(REFS_CONFIG) && !canReadRef(REFS_CONFIG)) {