opendev/gerrit
Code Issues Proposed changes

Comment why followup action is hardcoded inside ActionJson

Browse Source 
Change-Id: I5fc116148cb4a8d361ae467a0016791db45dbc26
This commit is contained in:
Shawn Pearce
2015-07-17 13:33:22 -07:00
parent 920d3cbea6
commit 2efa6030fd
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-server/src/main/java/com/google/gerrit/server/change/ActionJson.java
View File

@@ -73,7 +73,10 @@ public class ActionJson {
userProvider)) { userProvider)) {
out.put(d.getId(), new ActionInfo(d)); out.put(d.getId(), new ActionInfo(d));
} }
// TODO(sbeller): why do we need to treat followup specially here?
// The followup action is a client-side only operation that does not
// have a server side handler. It must be manually registered into the
// resulting action map.
if (ctl.getChange().getStatus().isOpen()) { if (ctl.getChange().getStatus().isOpen()) {
UiAction.Description descr = new UiAction.Description(); UiAction.Description descr = new UiAction.Description();
PrivateInternals_UiActionDescription.setId(descr, "followup"); PrivateInternals_UiActionDescription.setId(descr, "followup");