diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Daemon.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Daemon.java index 3ff6451057..09fe5a3665 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Daemon.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Daemon.java @@ -87,6 +87,7 @@ import com.google.gerrit.sshd.SshKeyCacheImpl; import com.google.gerrit.sshd.SshModule; import com.google.gerrit.sshd.commands.DefaultCommandModule; import com.google.gerrit.sshd.commands.IndexCommandsModule; +import com.google.gerrit.sshd.plugin.LfsPluginAuthCommand; import com.google.inject.AbstractModule; import com.google.inject.Guice; import com.google.inject.Injector; @@ -439,7 +440,8 @@ public class Daemon extends SiteProgram { modules.add(new SshHostKeyModule()); } modules.add(new DefaultCommandModule(slave, - sysInjector.getInstance(DownloadConfig.class))); + sysInjector.getInstance(DownloadConfig.class), + sysInjector.getInstance(LfsPluginAuthCommand.Module.class))); if (!slave && indexType == IndexType.LUCENE) { modules.add(new IndexCommandsModule()); } diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/DefaultCommandModule.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/DefaultCommandModule.java index 62e929750c..c9cdbe05d5 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/DefaultCommandModule.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/DefaultCommandModule.java @@ -27,10 +27,13 @@ import com.google.gerrit.sshd.plugin.LfsPluginAuthCommand; /** Register the commands a Gerrit server supports. */ public class DefaultCommandModule extends CommandModule { private final DownloadConfig downloadConfig; + private final LfsPluginAuthCommand.Module lfsPluginAuthModule; - public DefaultCommandModule(boolean slave, DownloadConfig downloadCfg) { + public DefaultCommandModule(boolean slave, DownloadConfig downloadCfg, + LfsPluginAuthCommand.Module module) { slaveMode = slave; downloadConfig = downloadCfg; + lfsPluginAuthModule = module; } @Override @@ -124,7 +127,7 @@ public class DefaultCommandModule extends CommandModule { alias(logging, "ls", ListLoggingLevelCommand.class); alias(logging, "set", SetLoggingLevelCommand.class); - install(new LfsPluginAuthCommand.Module()); + install(lfsPluginAuthModule); } private boolean sshEnabled() { diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/plugin/LfsPluginAuthCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/plugin/LfsPluginAuthCommand.java index e79f8bbf42..0c8d024f1a 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/plugin/LfsPluginAuthCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/plugin/LfsPluginAuthCommand.java @@ -16,11 +16,13 @@ package com.google.gerrit.sshd.plugin; import com.google.gerrit.extensions.registration.DynamicItem; import com.google.gerrit.server.CurrentUser; +import com.google.gerrit.server.config.GerritServerConfig; import com.google.gerrit.sshd.CommandModule; import com.google.gerrit.sshd.SshCommand; import com.google.inject.Inject; import com.google.inject.Provider; +import org.eclipse.jgit.lib.Config; import org.kohsuke.args4j.Argument; import java.util.ArrayList; @@ -33,10 +35,19 @@ public class LfsPluginAuthCommand extends SshCommand { } public static class Module extends CommandModule { + private final boolean pluginProvided; + + @Inject + Module(@GerritServerConfig Config cfg) { + pluginProvided = cfg.getString("lfs", null, "plugin") != null; + } + @Override protected void configure() { - command("git-lfs-authenticate").to(LfsPluginAuthCommand.class); - DynamicItem.itemOf(binder(), LfsSshPluginAuth.class); + if (pluginProvided) { + command("git-lfs-authenticate").to(LfsPluginAuthCommand.class); + DynamicItem.itemOf(binder(), LfsSshPluginAuth.class); + } } } diff --git a/gerrit-war/src/main/java/com/google/gerrit/httpd/WebAppInitializer.java b/gerrit-war/src/main/java/com/google/gerrit/httpd/WebAppInitializer.java index 71eed63832..fb7d0e97ef 100644 --- a/gerrit-war/src/main/java/com/google/gerrit/httpd/WebAppInitializer.java +++ b/gerrit-war/src/main/java/com/google/gerrit/httpd/WebAppInitializer.java @@ -72,6 +72,7 @@ import com.google.gerrit.sshd.SshKeyCacheImpl; import com.google.gerrit.sshd.SshModule; import com.google.gerrit.sshd.commands.DefaultCommandModule; import com.google.gerrit.sshd.commands.IndexCommandsModule; +import com.google.gerrit.sshd.plugin.LfsPluginAuthCommand; import com.google.inject.AbstractModule; import com.google.inject.CreationException; import com.google.inject.Guice; @@ -356,7 +357,8 @@ public class WebAppInitializer extends GuiceServletContextListener modules.add(sysInjector.getInstance(SshModule.class)); modules.add(new SshHostKeyModule()); modules.add(new DefaultCommandModule(false, - sysInjector.getInstance(DownloadConfig.class))); + sysInjector.getInstance(DownloadConfig.class), + sysInjector.getInstance(LfsPluginAuthCommand.Module.class))); if (indexType == IndexType.LUCENE) { modules.add(new IndexCommandsModule()); }