opendev/gerrit
Code Issues Proposed changes

Allow to push a tag that points to a non-commit object

Browse Source 
This was fixed in 2.11.1 with change I013c75db9 but was then
inadvertently reverted by change If4a2375db which was included
in 2.11.2 and 2.11.3.

Redo the original fix.

Bug: Issue 3328
Change-Id: I85e5e1afc65b1408acd0754f6adbdb6742928aaf
This commit is contained in:
David Pursehouse
2015-09-09 09:37:54 +09:00
parent 5eb53d7ffd
commit 318953fdcd
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
View File

@@ -2382,7 +2382,11 @@ public class ReceiveCommits {
walk.sort(RevSort.NONE); walk.sort(RevSort.NONE);
try { try {
Set<ObjectId> existing = Sets.newHashSet(); Set<ObjectId> existing = Sets.newHashSet();
walk.markStart(walk.parseCommit(cmd.getNewId())); RevObject parsedObject = walk.parseAny(cmd.getNewId());
if (!(parsedObject instanceof RevCommit)) {
return;
}
walk.markStart((RevCommit)parsedObject);
markHeadsAsUninteresting(walk, existing, cmd.getRefName()); markHeadsAsUninteresting(walk, existing, cmd.getRefName());
RevCommit c; RevCommit c;