From 8001dc83f3b9118ab45c251239f2c7ba05458ff7 Mon Sep 17 00:00:00 2001 From: Joe Hansche Date: Fri, 18 May 2012 18:22:50 -0400 Subject: [PATCH] Initialize the submodule commit message buffer Appending to a String that is null causes the null value to be coerced to a string literal, such that the previously-null String value becomes a string literal "null". Change-Id: I07a4b071fabbb0b4a28403603884cb05d777c01b Bug: Issue 1396 --- .../main/java/com/google/gerrit/server/git/SubmoduleOp.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/SubmoduleOp.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/SubmoduleOp.java index 151cba4b72..0ca8793f61 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/SubmoduleOp.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/SubmoduleOp.java @@ -202,6 +202,9 @@ public class SubmoduleOp { if (!subscribers.isEmpty()) { String msgbuf = msg; if (msgbuf == null) { + // Initialize the message buffer + msgbuf = ""; + // The first updatedBranch on a cascade event of automatic // updates of repos is added to updatedSubscribers set so // if we face a situation having