Revert "Hide automated messages by default"

This reverts commit 3e6ab28add.

Reason for revert: There are some unintended consequences of this change
that require some additional thought and consideration. 

Change-Id: I45ec8291033df21584845c453116c1bd4dec8f1a
This commit is contained in:
Becky Siegel
2018-02-08 19:20:19 +00:00
parent 3e6ab28add
commit 31df8929a3
3 changed files with 12 additions and 10 deletions

View File

@@ -72,7 +72,7 @@ limitations under the License.
hidden$="[[!_hasAutomatedMessages(messages)]]">
<paper-toggle-button
id="automatedMessageToggle"
checked="{{!_hideAutomated}}"></paper-toggle-button>All activity
checked="{{_hideAutomated}}"></paper-toggle-button>Only comments
<span class="transparent separator"></span>
</span>
<gr-button

View File

@@ -49,7 +49,7 @@
},
_hideAutomated: {
type: Boolean,
value: true,
value: false,
},
/**
* The messages after processing and including merged reviewer updates.

View File

@@ -199,12 +199,13 @@ limitations under the License.
.concat(_.times(11, randomMessage));
flushAsynchronousOperations();
assert.isTrue(element.$.messageControlsContainer.hasAttribute('hidden'));
MockInteractions.tap(element.$.automatedMessageToggle);
flushAsynchronousOperations();
assert.equal(element.$.oldMessagesBtn.innerText.toUpperCase(),
'SHOW 1 MESSAGE');
assert.isFalse(element.$.messageControlsContainer.hasAttribute('hidden'));
MockInteractions.tap(element.$.automatedMessageToggle);
flushAsynchronousOperations();
assert.isTrue(element.$.messageControlsContainer.hasAttribute('hidden'));
});
test('message count still respects non-automated on toggle', () => {
@@ -476,23 +477,24 @@ limitations under the License.
assert.isNotOk(element.$$('#automatedMessageToggle[hidden]'));
});
test('autogenerated messages are hidden initially', () => {
test('autogenerated messages are not hidden initially', () => {
const allHiddenMessageEls = getHiddenMessages();
// There are no hidden messages.
assert.isTrue(!!allHiddenMessageEls.length);
assert.isFalse(!!allHiddenMessageEls.length);
});
test('autogenerated messages displayed after comments only toggle', () => {
test('autogenerated messages hidden after comments only toggle', () => {
let allHiddenMessageEls = getHiddenMessages();
element._hideAutomated = false;
MockInteractions.tap(element.$.automatedMessageToggle);
flushAsynchronousOperations();
allMessageEls = getMessages();
allHiddenMessageEls = getHiddenMessages();
// Autogenerated messages are now hidden.
assert.notEqual(allHiddenMessageEls.length, allMessageEls.length);
assert.isFalse(!!allHiddenMessageEls.length);
assert.equal(allHiddenMessageEls.length, allMessageEls.length);
});
test('autogenerated messages not hidden after comments only toggle',