opendev/gerrit
Code Issues Proposed changes

Fix: Also copy parentUuid in copy constructor of Comment

Browse Source 
The copy constructor is currently only used by the code which updates
a draft comment. Interestingly, nobody seemed to have noticed that this
REST API actually had a bug and the parentUuid was lost when the draft
comment was updated. Users of Gerrit's API didn't run into this bug
as the frontend always sends all comment parameters as input to the
draft update along.

By the way, this issue was noticed as a side-effect of testing the
implementation of another new feature (ported comments, see I4e96af5ac).
Writing even seemingly trivial tests (e.g. that the parentUuid of a
ported comment is kept as in the original) seemed to have paid off in
this case.

Change-Id: I75a65bd57fb71cb8efe9d2460bc210b557546165
This commit is contained in:
Alice Kober-Sotzek
2020-08-13 20:47:58 +02:00
parent efa8507bac
commit 322bf38e5c
2 changed files with 39 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/com/google/gerrit/entities/Comment.java
View File

@@ -244,6 +244,7 @@ public abstract class Comment {
c.unresolved);
this.lineNbr = c.lineNbr;
this.realAuthor = c.realAuthor;
this.parentUuid = c.parentUuid;
this.range = c.range != null ? new Range(c.range) : null;
this.tag = c.tag;
this.revId = c.revId;