opendev/gerrit
Code Issues Proposed changes

Enable and fix 'Statement unnecessarily nested within else clause' warnings

Browse Source 
Change-Id: Ida6df4593fc2ab3c11581309b2b4a638229ea093
This commit is contained in:
David Pursehouse
2016-06-01 21:20:02 +09:00
parent b88b47d4b1
commit 323247227d
132 changed files with 542 additions and 724 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccountGroupScreen.java
View File

@@ -48,9 +48,8 @@ public abstract class AccountGroupScreen extends MenuScreen {
private String getTabToken(final String token, final String tab) {
if (token.startsWith("/admin/groups/uuid-")) {
return toGroup(group.getGroupUUID(), tab);
} else {
return toGroup(group.getGroupId(), tab);
}
return toGroup(group.getGroupId(), tab);
}
@Override

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/RangeBox.java
View File

@@ -33,9 +33,8 @@ abstract class RangeBox extends Composite implements
public String render(Integer object) {
if (0 <= object) {
return "+" + object;
} else {
return String.valueOf(object);
}
return String.valueOf(object);
}
@Override