opendev/gerrit
Code Issues Proposed changes

Enable and fix 'Statement unnecessarily nested within else clause' warnings

Browse Source 
Change-Id: Ida6df4593fc2ab3c11581309b2b4a638229ea093
This commit is contained in:
David Pursehouse
2016-06-01 21:20:02 +09:00
parent b88b47d4b1
commit 323247227d
132 changed files with 542 additions and 724 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Header.java
View File

@@ -293,11 +293,10 @@ public class Header extends Composite {
hasNext = true;
}
return k;
} else {
link.getElement().getStyle().setVisibility(Visibility.HIDDEN);
keys.add(new UpToChangeCommand(patchSetId, 0, key));
return null;
}
link.getElement().getStyle().setVisibility(Visibility.HIDDEN);
keys.add(new UpToChangeCommand(patchSetId, 0, key));
return null;
}
private boolean shouldSkipFile(FileInfo curr, CommentsCollections comments) {
@@ -314,19 +313,17 @@ public class Header extends Composite {
FileInfo curr = files.get(i);
if (shouldSkipFile(curr, comments)) {
continue;
} else {
prevInfo = curr;
break;
}
prevInfo = curr;
break;
}
for (int i = currIndex + 1; i < files.length(); i++) {
FileInfo curr = files.get(i);
if (shouldSkipFile(curr, comments)) {
continue;
} else {
nextInfo = curr;
break;
}
nextInfo = curr;
break;
}
KeyCommand p = setupNav(prev, '[', PatchUtil.C.previousFileHelp(),
prevInfo);