opendev/gerrit
Code Issues Proposed changes

MyPasswordScreen: Fix default text in password field

Browse Source 
The default text says:

  "click 'generate' to revoke an old password"

but the label on the button is actually 'Generate Password'.

Change the text to be consistent with the label. At the same time,
move the text into the AccountConstants class.

Change-Id: I2220103237c71d653f62fbf76ea866604f195d65
This commit is contained in:
David Pursehouse
2018-06-12 17:10:41 +09:00
parent f33b4e5aa9
commit 32b6adfade
3 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/AccountConstants.java
View File

@@ -127,6 +127,8 @@ public interface AccountConstants extends Constants {
String buttonGeneratePassword();
String revokePassword();
String linkObtainPassword();
String linkEditFullName();

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/AccountConstants.properties
View File

@@ -73,6 +73,7 @@ confirmSetUserNameTitle = Confirm Setting the Username
confirmSetUserName = Setting the Username is permanent. Are you sure?
buttonClearPassword = Clear Password
buttonGeneratePassword = Generate Password
revokePassword = (click 'Generate Password' to revoke an old password)
linkObtainPassword = Obtain Password
linkEditFullName = Edit
linkReloadContact = Reload

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyPasswordScreen.java
View File

@@ -49,7 +49,7 @@ public class MyPasswordScreen extends SettingsScreen {
return;
}
password = new CopyableLabel("(click 'generate' to revoke an old password)");
password = new CopyableLabel(Util.C.revokePassword());
password.addStyleName(Gerrit.RESOURCES.css().accountPassword());
generatePassword = new Button(Util.C.buttonGeneratePassword());