opendev/gerrit
Code Issues Proposed changes

Revert "Refactor ChangeSet#changesByProject() to return ChangeData"

Browse Source 
This reverts commit 6a5ae5f6a7.  It broke
anonymous access.

Also add a test to ensure it doesn't break again.

Change-Id: Ie28ea813a787728c78064fb262727919e8da69a0
This commit is contained in:
Jonathan Nieder
2016-06-10 12:16:40 -07:00
parent 558e2c02d7
commit 32ee1b7b5e
3 changed files with 41 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/server/change/SubmittedTogetherIT.java
View File

@@ -51,6 +51,17 @@ public class SubmittedTogetherIT extends AbstractDaemonTest {
assertSubmittedTogether(id2, id2, id1);
}
@Test
public void anonymousAncestors() throws Exception {
RevCommit a = commitBuilder().add("a", "1").message("change 1").create();
RevCommit b = commitBuilder().add("b", "1").message("change 2").create();
pushHead(testRepo, "refs/for/master", false);
setApiUserAnonymous();
assertSubmittedTogether(getChangeId(a));
assertSubmittedTogether(getChangeId(b), getChangeId(b), getChangeId(a));
}
@Test
public void respectsWholeTopicAndAncestors() throws Exception {
RevCommit initialHead = getRemoteHead();
@@ -79,6 +90,28 @@ public class SubmittedTogetherIT extends AbstractDaemonTest {
}
}
@Test
public void anonymousWholeTopic() throws Exception {
RevCommit initialHead = getRemoteHead();
RevCommit a = commitBuilder().add("a", "1").message("change 1").create();
pushHead(testRepo, "refs/for/master/" + name("topic"), false);
String id1 = getChangeId(a);
testRepo.reset(initialHead);
RevCommit b = commitBuilder().add("b", "1").message("change 2").create();
pushHead(testRepo, "refs/for/master/" + name("topic"), false);
String id2 = getChangeId(b);
setApiUserAnonymous();
if (isSubmitWholeTopicEnabled()) {
assertSubmittedTogether(id1, id2, id1);
assertSubmittedTogether(id2, id2, id1);
} else {
assertSubmittedTogether(id1);
assertSubmittedTogether(id2);
}
}
@Test
public void testTopicChaining() throws Exception {
RevCommit initialHead = getRemoteHead();