opendev/gerrit
Code Issues Proposed changes

Allow totally empty lines of diff content

Browse Source 
Empty diff lines had been coerced to non-breaking spaces in order to
preserve blank lines when copying to the clipboard [1]. Since then, copy
was upgraded to traverse the diff object rather than the DOM [2],
thereby obviating the need for non-breaking space to preserve blank
lines.

Remove the non-breaking space.

[1] 613b49c6
[2] 9fcec743

Bug: Issue 4854
Change-Id: I4039c76d996ed97e9fb237f2f6ca20f70be77675
This commit is contained in:
Wyatt Allen
2016-11-23 10:33:09 -08:00
parent c391eda75d
commit 32fb1d9e2b
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js
View File

@@ -384,9 +384,6 @@
var text = line.text; var text = line.text;
if (line.type !== GrDiffLine.Type.BLANK) { if (line.type !== GrDiffLine.Type.BLANK) {
td.classList.add('content'); td.classList.add('content');
if (!text) {
text = '\xa0';
}
} }
td.classList.add(line.type); td.classList.add(line.type);
var html = util.escapeHTML(text); var html = util.escapeHTML(text);