opendev/gerrit
Code Issues Proposed changes

Clean up final static to be static final

Browse Source 
Change-Id: I3abd97e25060544ffc379048e49ebd4f102d9292
This commit is contained in:
David Ostrovsky 2013-08-19 07:59:04 +02:00
parent 1cdfa1fdc8
commit 33653f9216
8 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/git/PushOneCommit.java
View File

@ -46,10 +46,10 @@ import java.util.Arrays;
import java.util.Set;
public class PushOneCommit {
public final static String SUBJECT = "test commit";
public static final String SUBJECT = "test commit";
private final static String FILE_NAME = "a.txt";
private final static String FILE_CONTENT = "some content";
private static final String FILE_NAME = "a.txt";
private static final String FILE_CONTENT = "some content";
private final ReviewDb db;
private final PersonIdent i;

2
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/CacheControl.java
View File

@ -22,7 +22,7 @@ public class CacheControl {
NONE, PUBLIC, PRIVATE;
}
public final static CacheControl NONE = new CacheControl(Type.NONE, 0, null);
public static final CacheControl NONE = new CacheControl(Type.NONE, 0, null);
public static CacheControl PUBLIC(long age, TimeUnit unit) {
return new CacheControl(Type.PUBLIC, age, unit);

14
gerrit-gwtui/src/main/java/com/google/gerrit/client/RelativeDateFormatter.java
View File

@ -23,19 +23,19 @@ import java.util.Date;
* in the format defined by {@code git log --relative-date}.
*/
public class RelativeDateFormatter {
final static long SECOND_IN_MILLIS = 1000;
static final long SECOND_IN_MILLIS = 1000;
final static long MINUTE_IN_MILLIS = 60 * SECOND_IN_MILLIS;
static final long MINUTE_IN_MILLIS = 60 * SECOND_IN_MILLIS;
final static long HOUR_IN_MILLIS = 60 * MINUTE_IN_MILLIS;
static final long HOUR_IN_MILLIS = 60 * MINUTE_IN_MILLIS;
final static long DAY_IN_MILLIS = 24 * HOUR_IN_MILLIS;
static final long DAY_IN_MILLIS = 24 * HOUR_IN_MILLIS;
final static long WEEK_IN_MILLIS = 7 * DAY_IN_MILLIS;
static final long WEEK_IN_MILLIS = 7 * DAY_IN_MILLIS;
final static long MONTH_IN_MILLIS = 30 * DAY_IN_MILLIS;
static final long MONTH_IN_MILLIS = 30 * DAY_IN_MILLIS;
final static long YEAR_IN_MILLIS = 365 * DAY_IN_MILLIS;
static final long YEAR_IN_MILLIS = 365 * DAY_IN_MILLIS;
/**
* @param when {@link Date} to format

4
gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/InitPlugins.java
View File

@ -35,8 +35,8 @@ import java.util.zip.ZipFile;
@Singleton
public class InitPlugins implements InitStep {
private final static String PLUGIN_DIR = "WEB-INF/plugins/";
private final static String JAR = ".jar";
private static final String PLUGIN_DIR = "WEB-INF/plugins/";
private static final String JAR = ".jar";
public static class PluginData {
public final String name;

2
gerrit-server/src/main/java/com/google/gerrit/server/auth/AuthUser.java
View File

@ -26,7 +26,7 @@ public class AuthUser {
/**
* Globally unique identifier for the user.
*/
public final static class UUID {
public static final class UUID {
private final String uuid;
/**

4
gerrit-server/src/main/java/com/google/gerrit/server/change/PostReviewers.java
View File

@ -63,8 +63,8 @@ import java.util.List;
import java.util.Set;
public class PostReviewers implements RestModifyView<ChangeResource, Input> {
public final static int DEFAULT_MAX_REVIEWERS_WITHOUT_CHECK = 10;
public final static int DEFAULT_MAX_REVIEWERS = 20;
public static final int DEFAULT_MAX_REVIEWERS_WITHOUT_CHECK = 10;
public static final int DEFAULT_MAX_REVIEWERS = 20;
public static class Input {
@DefaultInput

2
gerrit-server/src/main/java/com/google/gerrit/server/git/MergeUtil.java
View File

@ -488,7 +488,7 @@ public class MergeUtil {
public ObjectInserter createDryRunInserter() {
return new ObjectInserter() {
private final MutableObjectId buf = new MutableObjectId();
private final static int LAST_BYTE = Constants.OBJECT_ID_LENGTH - 1;
private static final int LAST_BYTE = Constants.OBJECT_ID_LENGTH - 1;
@Override
public ObjectId insert(int objectType, long length, InputStream in)

4
gerrit-server/src/test/java/com/google/gerrit/server/util/SubmoduleSectionParserTest.java
View File

@ -41,7 +41,7 @@ import java.util.TreeMap;
import java.util.TreeSet;
public class SubmoduleSectionParserTest extends LocalDiskRepositoryTestCase {
private final static String THIS_SERVER = "localhost";
private static final String THIS_SERVER = "localhost";
private GitRepositoryManager repoManager;
private BlobBasedConfig bbc;
@ -245,7 +245,7 @@ public class SubmoduleSectionParserTest extends LocalDiskRepositoryTestCase {
assertEquals(expectedSubscriptions, returnedSubscriptions);
}
private final static class SubmoduleSection {
private static final class SubmoduleSection {
private final String url;
private final String path;
private final String branch;