opendev/gerrit
Code Issues Proposed changes

Rename the "Diff All" change constants, they aren't buttons anymore

Browse Source 
Change-Id: I367368bbd37944d3132c2f4ba278705933b8db19
This commit is contained in:
Chad Horohoe
2012-12-02 07:43:21 -05:00
parent 213d5ec4cd
commit 33c3646ada
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.java
View File

@@ -167,6 +167,6 @@ public interface ChangeConstants extends Constants {
String submitFailed(); String submitFailed();
String buttonClose(); String buttonClose();
String buttonDiffAllSideBySide(); String diffAllSideBySide();
String buttonDiffAllUnified(); String diffAllUnified();
} }

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties
View File

@@ -148,5 +148,5 @@ reviewed = Reviewed
submitFailed = Submit Failed submitFailed = Submit Failed
buttonClose = Close buttonClose = Close
buttonDiffAllSideBySide = All Side-by-Side diffAllSideBySide = All Side-by-Side
buttonDiffAllUnified = All Unified diffAllUnified = All Unified

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchTable.java
View File

@@ -436,7 +436,7 @@ public class PatchTable extends Composite {
} }
void initializeLastRow(int row) { void initializeLastRow(int row) {
Anchor sideBySide = new Anchor(Util.C.buttonDiffAllSideBySide()); Anchor sideBySide = new Anchor(Util.C.diffAllSideBySide());
sideBySide.addClickHandler(new ClickHandler() { sideBySide.addClickHandler(new ClickHandler() {
@Override @Override
public void onClick(ClickEvent event) { public void onClick(ClickEvent event) {
@@ -448,7 +448,7 @@ public class PatchTable extends Composite {
table.setWidget(row, C_SIDEBYSIDE - 2, sideBySide); table.setWidget(row, C_SIDEBYSIDE - 2, sideBySide);
int C_UNIFIED = C_SIDEBYSIDE - 2 + 1; int C_UNIFIED = C_SIDEBYSIDE - 2 + 1;
Anchor unified = new Anchor(Util.C.buttonDiffAllUnified()); Anchor unified = new Anchor(Util.C.diffAllUnified());
unified.addClickHandler(new ClickHandler() { unified.addClickHandler(new ClickHandler() {
public void onClick(ClickEvent event) { public void onClick(ClickEvent event) {
for (Patch p : detail.getPatches()) { for (Patch p : detail.getPatches()) {