opendev/gerrit
Code Issues Proposed changes

Rename modify-reviewers command to set-reviewers

Browse Source 
Feedback from several persons showed that 'set-reviewers' would be the
better name for the 'modify-reviewers' SSH command, thus renaming it.

Change-Id: I466b563307adbf9bd36c095b899de6b9e694fcb5
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2011-07-11 22:00:57 +02:00
parent 5e65d9b2d5
commit 33e92d0d56
5 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Documentation/cmd-index.txt
View File

@@ -57,7 +57,7 @@ see link:user-upload.html#test_ssh[Testing Your SSH Connection].
link:cmd-ls-projects.html[gerrit ls-projects]:: link:cmd-ls-projects.html[gerrit ls-projects]::
List projects visible to the caller. List projects visible to the caller.
link:cmd-modify-reviewers.html[gerrit modify-reviewers]:: link:cmd-set-reviewers.html[gerrit set-reviewers]::
Add or remove reviewers on a change. Add or remove reviewers on a change.
link:cmd-query.html[gerrit query]:: link:cmd-query.html[gerrit query]::

12
Documentation/cmd-modify-reviewers.txt → Documentation/cmd-set-reviewers.txt
View File

@@ -1,14 +1,14 @@
gerrit modify-reviewers gerrit set-reviewers
======================= =======================
NAME NAME
---- ----
gerrit modify-reviewers - Add or remove reviewers to a change gerrit set-reviewers - Add or remove reviewers to a change
SYNOPSIS SYNOPSIS
-------- --------
[verse] [verse]
'ssh' -p <port> <host> 'gerrit modify-reviewers' 'ssh' -p <port> <host> 'gerrit set-reviewers'
[--project <PROJECT>] [--project <PROJECT>]
[--add REVIEWER ...] [--add REVIEWER ...]
[--remove REVIEWER ...] [--remove REVIEWER ...]
@@ -63,7 +63,7 @@ EXAMPLES
Add reviewers alice and bob, but remove eve from change Iac6b2ac2. Add reviewers alice and bob, but remove eve from change Iac6b2ac2.
===== =====
$ ssh -p 29418 review.example.com gerrit modify-reviewers \ $ ssh -p 29418 review.example.com gerrit set-reviewers \
-a alice@example.com -a bob@example.com \ -a alice@example.com -a bob@example.com \
-r eve@example.com \ -r eve@example.com \
Iac6b2ac2 Iac6b2ac2
@@ -71,7 +71,7 @@ Add reviewers alice and bob, but remove eve from change Iac6b2ac2.
Add reviewer elvis to old-style change id 1935 specifying that the change is in project "graceland" Add reviewer elvis to old-style change id 1935 specifying that the change is in project "graceland"
===== =====
$ ssh -p 29418 review.example.com gerrit modify-reviewers \ $ ssh -p 29418 review.example.com gerrit set-reviewers \
--project graceland \ --project graceland \
-a elvis@example.com \ -a elvis@example.com \
1935 1935
@@ -79,7 +79,7 @@ Add reviewer elvis to old-style change id 1935 specifying that the change is in
Add all project owners as reviewers to change Iac6b2ac2. Add all project owners as reviewers to change Iac6b2ac2.
===== =====
$ ssh -p 29418 review.example.com gerrit modify-reviewers \ $ ssh -p 29418 review.example.com gerrit set-reviewers \
-a "'Project Owners'" \ -a "'Project Owners'" \
Iac6b2ac2 Iac6b2ac2
===== =====

2
Documentation/config-gerrit.txt
View File

@@ -39,7 +39,7 @@ Default is 10.
+ +
This setting only applies for adding reviewers in the Gerrit WebUI, This setting only applies for adding reviewers in the Gerrit WebUI,
but is ignored when adding reviewers with the but is ignored when adding reviewers with the
link:cmd-modify-reviewers.html[modify-reviewers] command. link:cmd-set-reviewers.html[set-reviewers] command.
[[addreviewer.maxAllowed]]addreviewer.maxAllowed:: [[addreviewer.maxAllowed]]addreviewer.maxAllowed::
+ +

2
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/MasterCommandModule.java
View File

@@ -30,7 +30,7 @@ public class MasterCommandModule extends CommandModule {
command(gerrit, "create-group").to(CreateGroupCommand.class); command(gerrit, "create-group").to(CreateGroupCommand.class);
command(gerrit, "create-project").to(CreateProject.class); command(gerrit, "create-project").to(CreateProject.class);
command(gerrit, "gsql").to(AdminQueryShell.class); command(gerrit, "gsql").to(AdminQueryShell.class);
command(gerrit, "modify-reviewers").to(ModifyReviewersCommand.class); command(gerrit, "set-reviewers").to(SetReviewersCommand.class);
command(gerrit, "receive-pack").to(Receive.class); command(gerrit, "receive-pack").to(Receive.class);
command(gerrit, "replicate").to(Replicate.class); command(gerrit, "replicate").to(Replicate.class);
command(gerrit, "set-project-parent").to(AdminSetParent.class); command(gerrit, "set-project-parent").to(AdminSetParent.class);

4
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ModifyReviewersCommand.java → gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetReviewersCommand.java
View File

@@ -43,9 +43,9 @@ import java.util.HashSet;
import java.util.List; import java.util.List;
import java.util.Set; import java.util.Set;
public class ModifyReviewersCommand extends BaseCommand { public class SetReviewersCommand extends BaseCommand {
private static final Logger log = private static final Logger log =
LoggerFactory.getLogger(ModifyReviewersCommand.class); LoggerFactory.getLogger(SetReviewersCommand.class);
@Option(name = "--project", aliases = "-p", usage = "project containing the change") @Option(name = "--project", aliases = "-p", usage = "project containing the change")
private ProjectControl projectControl; private ProjectControl projectControl;