diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/auth/oauth/OAuthServiceProvider.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/auth/oauth/OAuthServiceProvider.java index 8375e3179e..9be2630792 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/auth/oauth/OAuthServiceProvider.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/auth/oauth/OAuthServiceProvider.java @@ -22,30 +22,21 @@ import java.io.IOException; @ExtensionPoint public interface OAuthServiceProvider { - /** - * Retrieve the request token. - * - * @return request token - */ - OAuthToken getRequestToken(); - /** * Returns the URL where you should redirect your users to authenticate * your application. * - * @param requestToken the request token you need to authorize - * @return the URL where you should redirect your users + * @return the OAuth service URL to redirect your users for authentication */ - String getAuthorizationUrl(OAuthToken requestToken); + String getAuthorizationUrl(); /** * Retrieve the access token * - * @param requestToken request token (obtained previously) * @param verifier verifier code * @return access token */ - OAuthToken getAccessToken(OAuthToken requestToken, OAuthVerifier verifier); + OAuthToken getAccessToken(OAuthVerifier verifier); /** * After establishing of secure communication channel, this method supossed to diff --git a/gerrit-oauth/src/main/java/com/google/gerrit/httpd/auth/oauth/OAuthSession.java b/gerrit-oauth/src/main/java/com/google/gerrit/httpd/auth/oauth/OAuthSession.java index d625e02abd..3eba6d9492 100644 --- a/gerrit-oauth/src/main/java/com/google/gerrit/httpd/auth/oauth/OAuthSession.java +++ b/gerrit-oauth/src/main/java/com/google/gerrit/httpd/auth/oauth/OAuthSession.java @@ -87,8 +87,7 @@ class OAuthSession { } log.debug("Login-Retrieve-User " + this); - token = oauth.getAccessToken(null, - new OAuthVerifier(request.getParameter("code"))); + token = oauth.getAccessToken(new OAuthVerifier(request.getParameter("code"))); user = oauth.getUserInfo(token); @@ -103,7 +102,7 @@ class OAuthSession { } else { log.debug("Login-PHASE1 " + this); redirectUrl = request.getRequestURI(); - response.sendRedirect(oauth.getAuthorizationUrl(null) + + response.sendRedirect(oauth.getAuthorizationUrl() + "&state=" + state); return false; }