opendev/gerrit
Code Issues Proposed changes

Fix PUT /accounts/{id}/preferences

Browse Source 
Docs said use PUT, but the implementation was using POST.  The sister
API of diff.preferences uses PUT, so use PUT.

Change-Id: Ied72c36aa74ff07c1666ba60f0cc32b03cc841d5
This commit is contained in:
Shawn Pearce
2014-12-29 22:20:16 -05:00
parent 7589bc6925
commit 343d50151b
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyPreferencesScreen.java
View File

@@ -409,7 +409,7 @@ public class MyPreferencesScreen extends SettingsScreen {
}
AccountApi.self().view("preferences")
.post(Preferences.create(p, items), new GerritCallback<Preferences>() {
.put(Preferences.create(p, items), new GerritCallback<Preferences>() {
@Override
public void onSuccess(Preferences prefs) {
Gerrit.getUserAccount().setGeneralPreferences(p);

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DownloadBox.java
View File

@@ -270,7 +270,7 @@ class DownloadBox extends VerticalPanel {
PreferenceInput in = PreferenceInput.create();
in.download_scheme(scheme);
AccountApi.self().view("preferences")
.post(in, new AsyncCallback<JavaScriptObject>() {
.put(in, new AsyncCallback<JavaScriptObject>() {
@Override
public void onSuccess(JavaScriptObject result) {
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/NewChangeScreenBar.java
View File

@@ -84,7 +84,7 @@ class NewChangeScreenBar extends Composite {
Prefs in = Prefs.createObject().cast();
in.change_screen(sel.name());
AccountApi.self().view("preferences").background().post(in,
AccountApi.self().view("preferences").background().put(in,
new AsyncCallback<JavaScriptObject>() {
@Override public void onFailure(Throwable caught) {}
@Override public void onSuccess(JavaScriptObject result) {}

2
gerrit-server/src/main/java/com/google/gerrit/server/account/Module.java
View File

@@ -62,7 +62,7 @@ public class Module extends RestApiModule {
child(ACCOUNT_KIND, "capabilities").to(Capabilities.class);
get(ACCOUNT_KIND, "groups").to(GetGroups.class);
get(ACCOUNT_KIND, "preferences").to(GetPreferences.class);
post(ACCOUNT_KIND, "preferences").to(SetPreferences.class);
put(ACCOUNT_KIND, "preferences").to(SetPreferences.class);
get(ACCOUNT_KIND, "preferences.diff").to(GetDiffPreferences.class);
put(ACCOUNT_KIND, "preferences.diff").to(SetDiffPreferences.class);
get(CAPABILITY_KIND).to(GetCapabilities.CheckOne.class);