opendev/gerrit
Code Issues Proposed changes

Fix display of active row marker in tag list

Browse Source 
Bug: Issue 3863
Change-Id: I3f1ed8d704ada9c231ee76dc9c3969725794b557
This commit is contained in:
David Pursehouse
2016-02-01 15:04:42 +09:00
parent 0046d69af6
commit 3458b21eac
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectTagsScreen.java
View File

@@ -109,12 +109,12 @@ public class ProjectTagsScreen extends PaginatedProjectScreen {
TagsTable() { TagsTable() {
table.setWidth(""); table.setWidth("");
table.setText(0, 0, Util.C.columnTagName()); table.setText(0, 1, Util.C.columnTagName());
table.setText(0, 1, Util.C.columnBranchRevision()); table.setText(0, 2, Util.C.columnBranchRevision());
FlexCellFormatter fmt = table.getFlexCellFormatter(); FlexCellFormatter fmt = table.getFlexCellFormatter();
fmt.addStyleName(0, 0, Gerrit.RESOURCES.css().dataHeader());
fmt.addStyleName(0, 1, Gerrit.RESOURCES.css().dataHeader()); fmt.addStyleName(0, 1, Gerrit.RESOURCES.css().dataHeader());
fmt.addStyleName(0, 2, Gerrit.RESOURCES.css().dataHeader());
} }
void display(List<TagInfo> tags) { void display(List<TagInfo> tags) {
@@ -135,18 +135,18 @@ public class ProjectTagsScreen extends PaginatedProjectScreen {
} }
void populate(int row, TagInfo k) { void populate(int row, TagInfo k) {
table.setWidget(row, 0, new InlineHTML(highlight(k.getShortName(), match))); table.setWidget(row, 1, new InlineHTML(highlight(k.getShortName(), match)));
if (k.revision() != null) { if (k.revision() != null) {
table.setText(row, 1, k.revision()); table.setText(row, 2, k.revision());
} else { } else {
table.setText(row, 1, ""); table.setText(row, 2, "");
} }
FlexCellFormatter fmt = table.getFlexCellFormatter(); FlexCellFormatter fmt = table.getFlexCellFormatter();
String dataCellStyle = Gerrit.RESOURCES.css().dataCell(); String dataCellStyle = Gerrit.RESOURCES.css().dataCell();
fmt.addStyleName(row, 0, dataCellStyle);
fmt.addStyleName(row, 1, dataCellStyle); fmt.addStyleName(row, 1, dataCellStyle);
fmt.addStyleName(row, 2, dataCellStyle);
setRowItem(row, k); setRowItem(row, k);
} }