diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/auth/openid/OpenIdService.java b/gerrit-common/src/main/java/com/google/gerrit/common/auth/openid/OpenIdService.java index 0a24cd5b00..0deba3416b 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/auth/openid/OpenIdService.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/auth/openid/OpenIdService.java @@ -15,11 +15,11 @@ package com.google.gerrit.common.auth.openid; import com.google.gerrit.common.auth.SignInMode; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.AllowCrossSiteRequest; -import com.google.gwtjsonrpc.client.RemoteJsonService; -import com.google.gwtjsonrpc.client.RpcImpl; -import com.google.gwtjsonrpc.client.RpcImpl.Version; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.AllowCrossSiteRequest; +import com.google.gwtjsonrpc.common.RemoteJsonService; +import com.google.gwtjsonrpc.common.RpcImpl; +import com.google.gwtjsonrpc.common.RpcImpl.Version; @RpcImpl(version = Version.V2_0) public interface OpenIdService extends RemoteJsonService { diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/auth/userpass/UserPassAuthService.java b/gerrit-common/src/main/java/com/google/gerrit/common/auth/userpass/UserPassAuthService.java index 5f39bc396f..1d25a3dff1 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/auth/userpass/UserPassAuthService.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/auth/userpass/UserPassAuthService.java @@ -14,11 +14,11 @@ package com.google.gerrit.common.auth.userpass; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.AllowCrossSiteRequest; -import com.google.gwtjsonrpc.client.RemoteJsonService; -import com.google.gwtjsonrpc.client.RpcImpl; -import com.google.gwtjsonrpc.client.RpcImpl.Version; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.AllowCrossSiteRequest; +import com.google.gwtjsonrpc.common.RemoteJsonService; +import com.google.gwtjsonrpc.common.RpcImpl; +import com.google.gwtjsonrpc.common.RpcImpl.Version; @RpcImpl(version = Version.V2_0) public interface UserPassAuthService extends RemoteJsonService { diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/AccountSecurity.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/AccountSecurity.java index e70aec3f87..21aca692c5 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/AccountSecurity.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/AccountSecurity.java @@ -20,11 +20,11 @@ import com.google.gerrit.reviewdb.client.AccountExternalId; import com.google.gerrit.reviewdb.client.AccountSshKey; import com.google.gerrit.reviewdb.client.ContactInformation; import com.google.gerrit.reviewdb.client.ContributorAgreement; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.RemoteJsonService; -import com.google.gwtjsonrpc.client.RpcImpl; -import com.google.gwtjsonrpc.client.RpcImpl.Version; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.RemoteJsonService; +import com.google.gwtjsonrpc.common.RpcImpl; +import com.google.gwtjsonrpc.common.VoidResult; +import com.google.gwtjsonrpc.common.RpcImpl.Version; import java.util.List; import java.util.Set; diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/AccountService.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/AccountService.java index 86372235bc..7377d7e84f 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/AccountService.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/AccountService.java @@ -19,11 +19,11 @@ import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.AccountDiffPreference; import com.google.gerrit.reviewdb.client.AccountGeneralPreferences; import com.google.gerrit.reviewdb.client.AccountProjectWatch; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.RemoteJsonService; -import com.google.gwtjsonrpc.client.RpcImpl; -import com.google.gwtjsonrpc.client.RpcImpl.Version; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.RemoteJsonService; +import com.google.gwtjsonrpc.common.RpcImpl; +import com.google.gwtjsonrpc.common.VoidResult; +import com.google.gwtjsonrpc.common.RpcImpl.Version; import java.util.List; import java.util.Set; diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeDetailService.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeDetailService.java index 59efcc51e1..8b436242f0 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeDetailService.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeDetailService.java @@ -18,10 +18,10 @@ import com.google.gerrit.common.auth.SignInRequired; import com.google.gerrit.reviewdb.client.AccountDiffPreference; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.PatchSet; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.RemoteJsonService; -import com.google.gwtjsonrpc.client.RpcImpl; -import com.google.gwtjsonrpc.client.RpcImpl.Version; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.RemoteJsonService; +import com.google.gwtjsonrpc.common.RpcImpl; +import com.google.gwtjsonrpc.common.RpcImpl.Version; @RpcImpl(version = Version.V2_0) public interface ChangeDetailService extends RemoteJsonService { diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeListService.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeListService.java index 89c2ac14ea..f646bc6f15 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeListService.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeListService.java @@ -17,11 +17,11 @@ package com.google.gerrit.common.data; import com.google.gerrit.common.auth.SignInRequired; import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Change; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.RemoteJsonService; -import com.google.gwtjsonrpc.client.RpcImpl; -import com.google.gwtjsonrpc.client.RpcImpl.Version; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.RemoteJsonService; +import com.google.gwtjsonrpc.common.RpcImpl; +import com.google.gwtjsonrpc.common.VoidResult; +import com.google.gwtjsonrpc.common.RpcImpl.Version; import java.util.Set; diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeManageService.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeManageService.java index 18453ca7b6..872bddc5d0 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeManageService.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeManageService.java @@ -16,11 +16,11 @@ package com.google.gerrit.common.data; import com.google.gerrit.common.auth.SignInRequired; import com.google.gerrit.reviewdb.client.PatchSet; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.RemoteJsonService; -import com.google.gwtjsonrpc.client.RpcImpl; -import com.google.gwtjsonrpc.client.RpcImpl.Version; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.RemoteJsonService; +import com.google.gwtjsonrpc.common.RpcImpl; +import com.google.gwtjsonrpc.common.VoidResult; +import com.google.gwtjsonrpc.common.RpcImpl.Version; @RpcImpl(version = Version.V2_0) public interface ChangeManageService extends RemoteJsonService { diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/GerritConfig.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/GerritConfig.java index e2b9d11ddf..456ffb4421 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/GerritConfig.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/GerritConfig.java @@ -29,7 +29,7 @@ public class GerritConfig implements Cloneable { protected String httpPasswordUrl; protected List allowedOpenIDs; - protected GitwebLink gitweb; + protected GitwebConfig gitweb; protected boolean useContributorAgreements; protected boolean useContactInfo; protected boolean allowRegisterNewEmail; @@ -86,11 +86,11 @@ public class GerritConfig implements Cloneable { downloadSchemes = s; } - public GitwebLink getGitwebLink() { + public GitwebConfig getGitwebLink() { return gitweb; } - public void setGitwebLink(final GitwebLink w) { + public void setGitwebLink(final GitwebConfig w) { gitweb = w; } diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/GitwebConfig.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/GitwebConfig.java new file mode 100644 index 0000000000..0503c60013 --- /dev/null +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/GitwebConfig.java @@ -0,0 +1,29 @@ +// Copyright (C) 2008 The Android Open Source Project +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package com.google.gerrit.common.data; + +/** Link to an external gitweb server. */ +public class GitwebConfig { + public String baseUrl; + public GitWebType type; + + protected GitwebConfig() { + } + + public GitwebConfig(final String base, final GitWebType gitWebType) { + baseUrl = base; + type = gitWebType; + } +} diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/GroupAdminService.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/GroupAdminService.java index 83a5156ed2..f385e27255 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/GroupAdminService.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/GroupAdminService.java @@ -18,11 +18,11 @@ import com.google.gerrit.common.auth.SignInRequired; import com.google.gerrit.reviewdb.client.AccountGroup; import com.google.gerrit.reviewdb.client.AccountGroupInclude; import com.google.gerrit.reviewdb.client.AccountGroupMember; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.RemoteJsonService; -import com.google.gwtjsonrpc.client.RpcImpl; -import com.google.gwtjsonrpc.client.RpcImpl.Version; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.RemoteJsonService; +import com.google.gwtjsonrpc.common.RpcImpl; +import com.google.gwtjsonrpc.common.VoidResult; +import com.google.gwtjsonrpc.common.RpcImpl.Version; import java.util.List; import java.util.Set; diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/PatchDetailService.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/PatchDetailService.java index f125e5f2bd..019154403e 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/PatchDetailService.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/PatchDetailService.java @@ -23,11 +23,11 @@ import com.google.gerrit.reviewdb.client.Patch; import com.google.gerrit.reviewdb.client.PatchLineComment; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gerrit.reviewdb.client.Patch.Key; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.RemoteJsonService; -import com.google.gwtjsonrpc.client.RpcImpl; -import com.google.gwtjsonrpc.client.RpcImpl.Version; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.RemoteJsonService; +import com.google.gwtjsonrpc.common.RpcImpl; +import com.google.gwtjsonrpc.common.VoidResult; +import com.google.gwtjsonrpc.common.RpcImpl.Version; import java.util.List; import java.util.Set; diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectAdminService.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectAdminService.java index e1a1be0bbc..1b504b07bc 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectAdminService.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectAdminService.java @@ -17,11 +17,11 @@ package com.google.gerrit.common.data; import com.google.gerrit.common.auth.SignInRequired; import com.google.gerrit.reviewdb.client.Branch; import com.google.gerrit.reviewdb.client.Project; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.RemoteJsonService; -import com.google.gwtjsonrpc.client.RpcImpl; -import com.google.gwtjsonrpc.client.RpcImpl.Version; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.RemoteJsonService; +import com.google.gwtjsonrpc.common.RpcImpl; +import com.google.gwtjsonrpc.common.VoidResult; +import com.google.gwtjsonrpc.common.RpcImpl.Version; import java.util.List; import java.util.Set; diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/SuggestService.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/SuggestService.java index 25d05e1099..85518b265a 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/SuggestService.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/SuggestService.java @@ -17,10 +17,10 @@ package com.google.gerrit.common.data; import com.google.gerrit.reviewdb.client.AccountGroup; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.Project; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.RemoteJsonService; -import com.google.gwtjsonrpc.client.RpcImpl; -import com.google.gwtjsonrpc.client.RpcImpl.Version; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.RemoteJsonService; +import com.google.gwtjsonrpc.common.RpcImpl; +import com.google.gwtjsonrpc.common.RpcImpl.Version; import java.util.List; diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/SystemInfoService.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/SystemInfoService.java index 26568eb8ec..78ccca1104 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/SystemInfoService.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/SystemInfoService.java @@ -16,12 +16,12 @@ package com.google.gerrit.common.data; import com.google.gerrit.common.auth.SignInRequired; import com.google.gerrit.reviewdb.client.ContributorAgreement; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.AllowCrossSiteRequest; -import com.google.gwtjsonrpc.client.RemoteJsonService; -import com.google.gwtjsonrpc.client.RpcImpl; -import com.google.gwtjsonrpc.client.RpcImpl.Version; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.AllowCrossSiteRequest; +import com.google.gwtjsonrpc.common.RemoteJsonService; +import com.google.gwtjsonrpc.common.RpcImpl; +import com.google.gwtjsonrpc.common.VoidResult; +import com.google.gwtjsonrpc.common.RpcImpl.Version; import java.util.List; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java index 9258a1f31e..6dbfeeefa8 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java @@ -29,6 +29,7 @@ import com.google.gerrit.common.ClientVersion; import com.google.gerrit.common.PageLinks; import com.google.gerrit.common.auth.SignInMode; import com.google.gerrit.common.data.GerritConfig; +import com.google.gerrit.common.data.GitwebConfig; import com.google.gerrit.common.data.HostPageData; import com.google.gerrit.common.data.SystemInfoService; import com.google.gerrit.reviewdb.client.Account; @@ -211,6 +212,11 @@ public class Gerrit implements EntryPoint { return myConfig; } + public static GitwebLink getGitwebLink() { + GitwebConfig gw = getConfig().getGitwebLink(); + return gw != null ? new GitwebLink(gw) : null; + } + /** Site theme information (site specific colors)/ */ public static HostPageData.Theme getTheme() { return myTheme; diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/GitwebLink.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/GitwebLink.java similarity index 90% rename from gerrit-common/src/main/java/com/google/gerrit/common/data/GitwebLink.java rename to gerrit-gwtui/src/main/java/com/google/gerrit/client/GitwebLink.java index 17b3834549..5f62a5260e 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/GitwebLink.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/GitwebLink.java @@ -12,8 +12,10 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.common.data; +package com.google.gerrit.client; +import com.google.gerrit.common.data.GitWebType; +import com.google.gerrit.common.data.ParameterizedString; import com.google.gerrit.reviewdb.client.Branch; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gerrit.reviewdb.client.Project; @@ -28,12 +30,9 @@ public class GitwebLink { protected GitWebType type; - protected GitwebLink() { - } - - public GitwebLink(final String base, final GitWebType gitWebType) { - baseUrl = base; - type = gitWebType; + public GitwebLink(com.google.gerrit.common.data.GitwebConfig link) { + baseUrl = link.baseUrl; + type = link.type; } public String getLinkName() { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/HostPageDataService.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/HostPageDataService.java index accec0a529..bd3d483aa3 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/HostPageDataService.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/HostPageDataService.java @@ -15,11 +15,11 @@ package com.google.gerrit.client; import com.google.gerrit.common.data.HostPageData; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.HostPageCache; -import com.google.gwtjsonrpc.client.RemoteJsonService; -import com.google.gwtjsonrpc.client.RpcImpl; -import com.google.gwtjsonrpc.client.RpcImpl.Version; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.HostPageCache; +import com.google.gwtjsonrpc.common.RemoteJsonService; +import com.google.gwtjsonrpc.common.RpcImpl; +import com.google.gwtjsonrpc.common.RpcImpl.Version; @RpcImpl(version = Version.V2_0) interface HostPageDataService extends RemoteJsonService { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/ContactPanelShort.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/ContactPanelShort.java index 8bb3573130..4e0b3b2147 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/ContactPanelShort.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/ContactPanelShort.java @@ -28,7 +28,7 @@ import com.google.gwt.event.dom.client.ChangeHandler; import com.google.gwt.event.dom.client.ClickEvent; import com.google.gwt.event.dom.client.ClickHandler; import com.google.gwt.i18n.client.LocaleInfo; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.Composite; import com.google.gwt.user.client.ui.FlowPanel; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyPreferencesScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyPreferencesScreen.java index 442fb3d38a..84e87aaa1b 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyPreferencesScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyPreferencesScreen.java @@ -33,7 +33,7 @@ import com.google.gwt.user.client.ui.CheckBox; import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.Grid; import com.google.gwt.user.client.ui.ListBox; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import java.util.Date; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyWatchesTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyWatchesTable.java index c8465cb5af..c158c2ca25 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyWatchesTable.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyWatchesTable.java @@ -28,7 +28,7 @@ import com.google.gwt.user.client.ui.CheckBox; import com.google.gwt.user.client.ui.FlexTable.FlexCellFormatter; import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.Label; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import java.util.HashSet; import java.util.List; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/NewAgreementScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/NewAgreementScreen.java index aa849a4522..b80c0f9fdb 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/NewAgreementScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/NewAgreementScreen.java @@ -34,7 +34,7 @@ import com.google.gwt.http.client.RequestBuilder; import com.google.gwt.http.client.RequestCallback; import com.google.gwt.http.client.RequestException; import com.google.gwt.http.client.Response; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.FormPanel; @@ -45,7 +45,7 @@ import com.google.gwt.user.client.ui.Panel; import com.google.gwt.user.client.ui.RadioButton; import com.google.gwt.user.client.ui.VerticalPanel; import com.google.gwtexpui.globalkey.client.NpTextBox; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import java.util.HashSet; import java.util.List; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/SshPanel.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/SshPanel.java index bc355cf523..73127f0e55 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/SshPanel.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/SshPanel.java @@ -39,7 +39,7 @@ import com.google.gwt.user.client.ui.VerticalPanel; import com.google.gwtexpui.clippy.client.CopyableLabel; import com.google.gwtexpui.globalkey.client.NpTextArea; import com.google.gwtjsonrpc.client.RemoteJsonException; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import java.util.Collections; import java.util.HashSet; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/UsernameField.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/UsernameField.java index c2c51c11ae..0666bb3b6a 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/UsernameField.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/UsernameField.java @@ -31,7 +31,7 @@ import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.TextBox; import com.google.gwtexpui.clippy.client.CopyableLabel; import com.google.gwtexpui.globalkey.client.NpTextBox; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; class UsernameField extends Composite { private CopyableLabel userNameLbl; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/ValidateEmailScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/ValidateEmailScreen.java index 4e54e85d72..1164efcdc9 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/ValidateEmailScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/ValidateEmailScreen.java @@ -18,7 +18,7 @@ import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.rpc.ScreenLoadCallback; import com.google.gerrit.client.ui.AccountScreen; import com.google.gerrit.common.PageLinks; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; public class ValidateEmailScreen extends AccountScreen { private final String magicToken; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccountGroupInfoScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccountGroupInfoScreen.java index 0d7bb2942f..4f071282a9 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccountGroupInfoScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccountGroupInfoScreen.java @@ -43,7 +43,7 @@ import com.google.gwt.user.client.ui.VerticalPanel; import com.google.gwtexpui.clippy.client.CopyableLabel; import com.google.gwtexpui.globalkey.client.NpTextArea; import com.google.gwtexpui.globalkey.client.NpTextBox; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import java.util.List; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccountGroupMembersScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccountGroupMembersScreen.java index 444b6f3db3..b5cca8627e 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccountGroupMembersScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AccountGroupMembersScreen.java @@ -38,7 +38,7 @@ import com.google.gwt.user.client.ui.CheckBox; import com.google.gwt.user.client.ui.FlexTable.FlexCellFormatter; import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.Panel; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import java.util.HashSet; import java.util.List; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/CreateProjectScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/CreateProjectScreen.java index a52bfa76f0..0ce2d775a7 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/CreateProjectScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/CreateProjectScreen.java @@ -36,7 +36,7 @@ import com.google.gwt.user.client.ui.Grid; import com.google.gwt.user.client.ui.SuggestBox; import com.google.gwt.user.client.ui.VerticalPanel; import com.google.gwtexpui.globalkey.client.NpTextBox; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import java.util.List; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectAccessEditor.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectAccessEditor.java index 306b405ed7..e3bf555b09 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectAccessEditor.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectAccessEditor.java @@ -16,9 +16,9 @@ package com.google.gerrit.client.admin; import com.google.gerrit.client.Dispatcher; import com.google.gerrit.client.Gerrit; +import com.google.gerrit.client.GitwebLink; import com.google.gerrit.client.ui.Hyperlink; import com.google.gerrit.common.data.AccessSection; -import com.google.gerrit.common.data.GitwebLink; import com.google.gerrit.common.data.ProjectAccess; import com.google.gerrit.reviewdb.client.Branch; import com.google.gerrit.reviewdb.client.Project; @@ -110,7 +110,7 @@ public class ProjectAccessEditor extends Composite implements inheritsFrom.getStyle().setDisplay(Display.NONE); } - final GitwebLink c = Gerrit.getConfig().getGitwebLink(); + final GitwebLink c = Gerrit.getGitwebLink(); if (value.isConfigVisible() && c != null) { history.getStyle().setDisplay(Display.BLOCK); gitweb.setText(c.getLinkName()); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectBranchesScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectBranchesScreen.java index f0d076f1bf..f3ecbb3719 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectBranchesScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectBranchesScreen.java @@ -17,11 +17,11 @@ package com.google.gerrit.client.admin; import com.google.gerrit.client.ConfirmationCallback; import com.google.gerrit.client.ConfirmationDialog; import com.google.gerrit.client.Gerrit; +import com.google.gerrit.client.GitwebLink; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.rpc.ScreenLoadCallback; import com.google.gerrit.client.ui.FancyFlexTable; import com.google.gerrit.client.ui.HintTextBox; -import com.google.gerrit.common.data.GitwebLink; import com.google.gerrit.common.data.ListBranchesResult; import com.google.gerrit.common.errors.InvalidNameException; import com.google.gerrit.common.errors.InvalidRevisionException; @@ -226,7 +226,7 @@ public class ProjectBranchesScreen extends ProjectScreen { fmt.addStyleName(0, 1, Gerrit.RESOURCES.css().iconHeader()); fmt.addStyleName(0, 2, Gerrit.RESOURCES.css().dataHeader()); fmt.addStyleName(0, 3, Gerrit.RESOURCES.css().dataHeader()); - if (Gerrit.getConfig().getGitwebLink() != null) { + if (Gerrit.getGitwebLink() != null) { fmt.addStyleName(0, 4, Gerrit.RESOURCES.css().dataHeader()); } } @@ -293,7 +293,7 @@ public class ProjectBranchesScreen extends ProjectScreen { } void populate(final int row, final Branch k) { - final GitwebLink c = Gerrit.getConfig().getGitwebLink(); + final GitwebLink c = Gerrit.getGitwebLink(); if (k.getCanDelete()) { table.setWidget(row, 1, new CheckBox()); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeDetailCache.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeDetailCache.java index 8f48ebd4b8..bb28e11639 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeDetailCache.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeDetailCache.java @@ -18,7 +18,7 @@ import com.google.gerrit.client.ui.ListenableValue; import com.google.gerrit.common.data.ChangeDetail; import com.google.gerrit.reviewdb.client.Change; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwt.user.client.ui.FocusWidget; public class ChangeDetailCache extends ListenableValue { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/DownloadCommandLink.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/DownloadCommandLink.java index 184add0279..c095d4d35e 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/DownloadCommandLink.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/DownloadCommandLink.java @@ -18,11 +18,11 @@ import com.google.gerrit.client.Gerrit; import com.google.gerrit.reviewdb.client.AccountGeneralPreferences; import com.google.gwt.event.dom.client.ClickEvent; import com.google.gwt.event.dom.client.ClickHandler; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwt.user.client.ui.Accessibility; import com.google.gwt.user.client.ui.Anchor; import com.google.gwt.user.client.ui.Widget; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; abstract class DownloadCommandLink extends Anchor implements ClickHandler { final AccountGeneralPreferences.DownloadCommand cmdType; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/DownloadUrlLink.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/DownloadUrlLink.java index 81c7cca5be..2afafaad3e 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/DownloadUrlLink.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/DownloadUrlLink.java @@ -18,11 +18,11 @@ import com.google.gerrit.client.Gerrit; import com.google.gerrit.reviewdb.client.AccountGeneralPreferences; import com.google.gwt.event.dom.client.ClickEvent; import com.google.gwt.event.dom.client.ClickHandler; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwt.user.client.ui.Accessibility; import com.google.gwt.user.client.ui.Anchor; import com.google.gwt.user.client.ui.Widget; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; class DownloadUrlLink extends Anchor implements ClickHandler { final AccountGeneralPreferences.DownloadScheme urlType; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PagedSingleListScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PagedSingleListScreen.java index 24713cf9fb..72300b2d99 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PagedSingleListScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PagedSingleListScreen.java @@ -24,7 +24,7 @@ import com.google.gerrit.common.data.SingleListChangeInfo; import com.google.gerrit.reviewdb.client.AccountGeneralPreferences; import com.google.gwt.event.dom.client.KeyPressEvent; import com.google.gwt.user.client.History; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwt.user.client.ui.HorizontalPanel; import com.google.gwtexpui.globalkey.client.KeyCommand; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java index 50a8a6aba3..81b4f140d5 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java @@ -17,6 +17,7 @@ package com.google.gerrit.client.changes; import com.google.gerrit.client.Dispatcher; import com.google.gerrit.client.FormatUtil; import com.google.gerrit.client.Gerrit; +import com.google.gerrit.client.GitwebLink; import com.google.gerrit.client.patches.PatchUtil; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.ui.AccountDashboardLink; @@ -25,7 +26,6 @@ import com.google.gerrit.client.ui.ComplexDisclosurePanel; import com.google.gerrit.client.ui.ListenableAccountDiffPreference; import com.google.gerrit.common.PageLinks; import com.google.gerrit.common.data.ChangeDetail; -import com.google.gerrit.common.data.GitwebLink; import com.google.gerrit.common.data.PatchSetDetail; import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.AccountDiffPreference; @@ -45,7 +45,6 @@ import com.google.gwt.event.dom.client.ClickHandler; import com.google.gwt.event.logical.shared.OpenEvent; import com.google.gwt.event.logical.shared.OpenHandler; import com.google.gwt.user.client.Window; -import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.ui.Anchor; import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.DisclosurePanel; @@ -56,7 +55,7 @@ import com.google.gwt.user.client.ui.HTMLTable.CellFormatter; import com.google.gwt.user.client.ui.InlineLabel; import com.google.gwt.user.client.ui.Panel; import com.google.gwtexpui.clippy.client.CopyableLabel; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import java.util.HashSet; import java.util.List; @@ -95,8 +94,7 @@ class PatchSetComplexDisclosurePanel extends ComplexDisclosurePanel body = new FlowPanel(); setContent(body); - final GitwebLink gw = Gerrit.getConfig().getGitwebLink(); - + final GitwebLink gw = Gerrit.getGitwebLink(); final InlineLabel revtxt = new InlineLabel(ps.getRevision().get() + " "); revtxt.addStyleName(Gerrit.RESOURCES.css().patchSetRevision()); getHeader().add(revtxt); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java index 58049b65ca..0c0849123f 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java @@ -47,7 +47,7 @@ import com.google.gwt.user.client.ui.RadioButton; import com.google.gwt.user.client.ui.VerticalPanel; import com.google.gwt.user.client.ui.Widget; import com.google.gwtexpui.globalkey.client.NpTextArea; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import java.util.ArrayList; import java.util.Collection; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/QueryScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/QueryScreen.java index 824845184d..cf9c526874 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/QueryScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/QueryScreen.java @@ -20,7 +20,7 @@ import com.google.gerrit.common.PageLinks; import com.google.gerrit.common.data.ChangeInfo; import com.google.gerrit.common.data.SingleListChangeInfo; import com.google.gerrit.reviewdb.client.RevId; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwtorm.client.KeyUtil; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/StarCache.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/StarCache.java index 7758843e46..5782b8fdaa 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/StarCache.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/StarCache.java @@ -33,7 +33,7 @@ import com.google.gwt.event.shared.HandlerManager; import com.google.gwt.event.shared.HandlerRegistration; import com.google.gwt.resources.client.ImageResource; import com.google.gwt.user.client.ui.Image; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; public class StarCache implements HasValueChangeHandlers { public class KeyCommand extends NeedsSignInKeyCommand { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/CommentEditorPanel.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/CommentEditorPanel.java index 99f509ce70..b0d825b148 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/CommentEditorPanel.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/CommentEditorPanel.java @@ -26,11 +26,11 @@ import com.google.gwt.event.dom.client.KeyCodes; import com.google.gwt.event.dom.client.KeyDownEvent; import com.google.gwt.event.dom.client.KeyDownHandler; import com.google.gwt.user.client.Timer; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.Widget; import com.google.gwtexpui.globalkey.client.NpTextArea; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import java.sql.Timestamp; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScreen.java index 112ad108ef..ffc896084e 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScreen.java @@ -38,14 +38,14 @@ import com.google.gwt.event.dom.client.KeyPressEvent; import com.google.gwt.event.logical.shared.ValueChangeEvent; import com.google.gwt.event.logical.shared.ValueChangeHandler; import com.google.gwt.event.shared.HandlerRegistration; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwt.user.client.ui.CheckBox; import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.Label; import com.google.gwtexpui.globalkey.client.GlobalKey; import com.google.gwtexpui.globalkey.client.KeyCommand; import com.google.gwtexpui.globalkey.client.KeyCommandSet; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; public abstract class PatchScreen extends Screen implements CommentEditorContainer { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScriptSettingsPanel.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScriptSettingsPanel.java index a02e3d4733..871eb2bd2d 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScriptSettingsPanel.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScriptSettingsPanel.java @@ -41,7 +41,7 @@ import com.google.gwt.user.client.ui.FocusWidget; import com.google.gwt.user.client.ui.HasWidgets; import com.google.gwt.user.client.ui.ListBox; import com.google.gwt.user.client.ui.Widget; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; public class PatchScriptSettingsPanel extends Composite implements HasValueChangeHandlers { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/rpc/GerritCallback.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/rpc/GerritCallback.java index 1871bb797b..98ae46f514 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/rpc/GerritCallback.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/rpc/GerritCallback.java @@ -24,11 +24,11 @@ import com.google.gerrit.common.errors.NoSuchEntityException; import com.google.gerrit.common.errors.NoSuchGroupException; import com.google.gerrit.common.errors.NotSignedInException; import com.google.gwt.core.client.GWT; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwt.user.client.rpc.InvocationException; -import com.google.gwtjsonrpc.client.JsonUtil; import com.google.gwtjsonrpc.client.RemoteJsonException; import com.google.gwtjsonrpc.client.ServerUnavailableException; +import com.google.gwtjsonrpc.common.JsonConstants; /** Abstract callback handling generic error conditions automatically */ public abstract class GerritCallback implements AsyncCallback { @@ -70,7 +70,7 @@ public abstract class GerritCallback implements AsyncCallback { private static boolean isInvalidXSRF(final Throwable caught) { return caught instanceof InvocationException - && caught.getMessage().equals(JsonUtil.ERROR_INVALID_XSRF); + && caught.getMessage().equals(JsonConstants.ERROR_INVALID_XSRF); } private static boolean isNotSignedIn(final Throwable caught) { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommentLinkProcessor.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommentLinkProcessor.java index f5ef2f48e8..a3c7a3c6fd 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommentLinkProcessor.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommentLinkProcessor.java @@ -15,10 +15,10 @@ package com.google.gerrit.client.ui; import com.google.gerrit.client.Gerrit; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwtexpui.safehtml.client.RegexFindReplace; import com.google.gwtexpui.safehtml.client.SafeHtml; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import java.util.ArrayList; import java.util.Collections; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommentedActionDialog.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommentedActionDialog.java index 19582445a3..26b61f53ef 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommentedActionDialog.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommentedActionDialog.java @@ -22,7 +22,7 @@ import com.google.gwt.event.dom.client.ClickHandler; import com.google.gwt.event.logical.shared.CloseEvent; import com.google.gwt.event.logical.shared.CloseHandler; import com.google.gwt.user.client.DOM; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.PopupPanel; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ListenableAccountDiffPreference.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ListenableAccountDiffPreference.java index 6dfd8631d5..27bc107e4b 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ListenableAccountDiffPreference.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ListenableAccountDiffPreference.java @@ -18,7 +18,7 @@ import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.account.Util; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.reviewdb.client.AccountDiffPreference; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; public class ListenableAccountDiffPreference extends ListenableOldValue { diff --git a/gerrit-httpd/pom.xml b/gerrit-httpd/pom.xml index 6c2190d55c..bee36747fc 100644 --- a/gerrit-httpd/pom.xml +++ b/gerrit-httpd/pom.xml @@ -54,11 +54,6 @@ limitations under the License. org.eclipse.jgit.junit - - com.google.gwt - gwt-servlet - - eu.medsea.mimeutil mime-util diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/GerritConfigProvider.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/GerritConfigProvider.java index 4f0b8dd1ba..1953480cce 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/GerritConfigProvider.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/GerritConfigProvider.java @@ -16,7 +16,7 @@ package com.google.gerrit.httpd; import com.google.gerrit.common.data.ApprovalTypes; import com.google.gerrit.common.data.GerritConfig; -import com.google.gerrit.common.data.GitwebLink; +import com.google.gerrit.common.data.GitwebConfig; import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.server.account.Realm; import com.google.gerrit.server.config.AllProjectsName; @@ -127,7 +127,7 @@ class GerritConfigProvider implements Provider { config.setEditableAccountFields(fields); if (gitWebConfig.getUrl() != null) { - config.setGitwebLink(new GitwebLink(gitWebConfig.getUrl(), gitWebConfig + config.setGitwebLink(new GitwebConfig(gitWebConfig.getUrl(), gitWebConfig .getGitWebType())); } diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/container/HttpAuthFilter.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/container/HttpAuthFilter.java index 1afd72de01..eb8a76b531 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/container/HttpAuthFilter.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/container/HttpAuthFilter.java @@ -17,7 +17,7 @@ package com.google.gerrit.httpd.auth.container; import com.google.gerrit.httpd.HtmlDomUtil; import com.google.gerrit.httpd.WebSession; import com.google.gerrit.httpd.raw.HostPageServlet; -import com.google.gwt.user.server.rpc.RPCServletUtils; +import com.google.gwtjsonrpc.server.RPCServletUtils; import com.google.inject.Inject; import com.google.inject.Provider; import com.google.inject.Singleton; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/ldap/UserPassAuthServiceImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/ldap/UserPassAuthServiceImpl.java index 1ed6030f3a..9d14872d3a 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/ldap/UserPassAuthServiceImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/ldap/UserPassAuthServiceImpl.java @@ -25,7 +25,7 @@ import com.google.gerrit.server.account.AuthRequest; import com.google.gerrit.server.account.AuthResult; import com.google.gerrit.server.auth.AuthenticationUnavailableException; import com.google.gerrit.server.config.AuthConfig; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.inject.Inject; import com.google.inject.Provider; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebCssServlet.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebCssServlet.java index a4df147497..e39796131c 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebCssServlet.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebCssServlet.java @@ -17,7 +17,7 @@ package com.google.gerrit.httpd.gitweb; import com.google.gerrit.httpd.GitWebConfig; import com.google.gerrit.httpd.HtmlDomUtil; import com.google.gerrit.server.config.SitePaths; -import com.google.gwt.user.server.rpc.RPCServletUtils; +import com.google.gwtjsonrpc.server.RPCServletUtils; import com.google.inject.Inject; import com.google.inject.Singleton; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/HostPageServlet.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/HostPageServlet.java index f105df0a55..6a43d95a1f 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/HostPageServlet.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/HostPageServlet.java @@ -22,7 +22,7 @@ import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.config.GerritServerConfig; import com.google.gerrit.server.config.SitePaths; -import com.google.gwt.user.server.rpc.RPCServletUtils; +import com.google.gwtjsonrpc.server.RPCServletUtils; import com.google.gwtexpui.linker.server.Permutation; import com.google.gwtexpui.linker.server.PermutationSelector; import com.google.gwtjsonrpc.server.JsonServlet; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/LegacyGerritServlet.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/LegacyGerritServlet.java index 5a72230931..d387f6e9b1 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/LegacyGerritServlet.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/LegacyGerritServlet.java @@ -15,7 +15,7 @@ package com.google.gerrit.httpd.raw; import com.google.gerrit.httpd.HtmlDomUtil; -import com.google.gwt.user.server.rpc.RPCServletUtils; +import com.google.gwtjsonrpc.server.RPCServletUtils; import com.google.inject.Inject; import com.google.inject.Singleton; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/StaticServlet.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/StaticServlet.java index c33a2aa7da..988dadb77a 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/StaticServlet.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/StaticServlet.java @@ -15,7 +15,7 @@ package com.google.gerrit.httpd.raw; import com.google.gerrit.server.config.SitePaths; -import com.google.gwt.user.server.rpc.RPCServletUtils; +import com.google.gwtjsonrpc.server.RPCServletUtils; import com.google.inject.Inject; import com.google.inject.Singleton; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/ToolServlet.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/ToolServlet.java index 4a688aa37a..810cc2a016 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/ToolServlet.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/ToolServlet.java @@ -25,7 +25,7 @@ import static org.eclipse.jgit.util.HttpSupport.HDR_PRAGMA; import com.google.gerrit.common.Version; import com.google.gerrit.server.tools.ToolsCatalog; import com.google.gerrit.server.tools.ToolsCatalog.Entry; -import com.google.gwt.user.server.rpc.RPCServletUtils; +import com.google.gwtjsonrpc.server.RPCServletUtils; import com.google.inject.Inject; import com.google.inject.Singleton; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/BaseServiceImplementation.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/BaseServiceImplementation.java index a29c48c332..26db6f9f79 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/BaseServiceImplementation.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/BaseServiceImplementation.java @@ -24,7 +24,7 @@ import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.project.NoSuchChangeException; import com.google.gerrit.server.project.NoSuchProjectException; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwtorm.server.OrmException; import com.google.inject.Provider; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/ChangeListServiceImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/ChangeListServiceImpl.java index 05641f189f..9a101d3ff0 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/ChangeListServiceImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/ChangeListServiceImpl.java @@ -39,8 +39,8 @@ import com.google.gerrit.server.query.change.ChangeData; import com.google.gerrit.server.query.change.ChangeDataSource; import com.google.gerrit.server.query.change.ChangeQueryBuilder; import com.google.gerrit.server.query.change.ChangeQueryRewriter; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.VoidResult; import com.google.gwtorm.server.ListResultSet; import com.google.gwtorm.server.OrmException; import com.google.gwtorm.server.ResultSet; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/GerritJsonServlet.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/GerritJsonServlet.java index 8840d20b7a..3513f89c15 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/GerritJsonServlet.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/GerritJsonServlet.java @@ -18,7 +18,7 @@ import com.google.gerrit.common.auth.SignInRequired; import com.google.gerrit.common.errors.NotSignedInException; import com.google.gerrit.httpd.WebSession; import com.google.gson.GsonBuilder; -import com.google.gwtjsonrpc.client.RemoteJsonService; +import com.google.gwtjsonrpc.common.RemoteJsonService; import com.google.gwtjsonrpc.server.ActiveCall; import com.google.gwtjsonrpc.server.JsonServlet; import com.google.gwtorm.server.OrmException; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/GerritJsonServletProvider.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/GerritJsonServletProvider.java index 823ee7a60a..9361130f61 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/GerritJsonServletProvider.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/GerritJsonServletProvider.java @@ -14,7 +14,7 @@ package com.google.gerrit.httpd.rpc; -import com.google.gwtjsonrpc.client.RemoteJsonService; +import com.google.gwtjsonrpc.common.RemoteJsonService; import com.google.inject.AbstractModule; import com.google.inject.Inject; import com.google.inject.Injector; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/Handler.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/Handler.java index a0980e1cdd..911d1cc543 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/Handler.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/Handler.java @@ -19,8 +19,8 @@ import com.google.gerrit.common.errors.NoSuchEntityException; import com.google.gerrit.server.project.NoSuchChangeException; import com.google.gerrit.server.project.NoSuchProjectException; import com.google.gerrit.server.project.NoSuchRefException; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.VoidResult; import com.google.gwtorm.server.OrmException; import java.util.concurrent.Callable; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/RpcServletModule.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/RpcServletModule.java index 29abee6382..876fee3a1f 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/RpcServletModule.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/RpcServletModule.java @@ -14,7 +14,7 @@ package com.google.gerrit.httpd.rpc; -import com.google.gwtjsonrpc.client.RemoteJsonService; +import com.google.gwtjsonrpc.common.RemoteJsonService; import com.google.inject.Key; import com.google.inject.Scopes; import com.google.inject.internal.UniqueAnnotations; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SuggestServiceImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SuggestServiceImpl.java index bd74f45e72..f3e8e65ea0 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SuggestServiceImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SuggestServiceImpl.java @@ -41,7 +41,7 @@ import com.google.gerrit.server.project.NoSuchChangeException; import com.google.gerrit.server.project.NoSuchProjectException; import com.google.gerrit.server.project.ProjectCache; import com.google.gerrit.server.project.ProjectControl; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; import com.google.inject.Provider; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SystemInfoServiceImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SystemInfoServiceImpl.java index bc3134ea44..9de7d88658 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SystemInfoServiceImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SystemInfoServiceImpl.java @@ -20,8 +20,8 @@ import com.google.gerrit.common.data.SystemInfoService; import com.google.gerrit.reviewdb.client.ContributorAgreement; import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.ssh.SshInfo; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.VoidResult; import com.google.gwtorm.server.OrmException; import com.google.gwtorm.server.SchemaFactory; import com.google.inject.Inject; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/AccountSecurityImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/AccountSecurityImpl.java index 501b87e6d4..aa94759f30 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/AccountSecurityImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/AccountSecurityImpl.java @@ -49,8 +49,8 @@ import com.google.gerrit.server.mail.EmailException; import com.google.gerrit.server.mail.EmailTokenVerifier; import com.google.gerrit.server.mail.RegisterNewEmailSender; import com.google.gerrit.server.ssh.SshKeyCache; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.VoidResult; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; import com.google.inject.Provider; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/AccountServiceImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/AccountServiceImpl.java index e40df1168d..2fe312445c 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/AccountServiceImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/AccountServiceImpl.java @@ -32,8 +32,8 @@ import com.google.gerrit.server.project.NoSuchProjectException; import com.google.gerrit.server.project.ProjectControl; import com.google.gerrit.server.query.QueryParseException; import com.google.gerrit.server.query.change.ChangeQueryBuilder; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.VoidResult; import com.google.gwtorm.server.OrmDuplicateKeyException; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/GroupAdminServiceImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/GroupAdminServiceImpl.java index f33c30a214..1adc4bdef0 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/GroupAdminServiceImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/account/GroupAdminServiceImpl.java @@ -38,8 +38,8 @@ import com.google.gerrit.server.account.GroupCache; import com.google.gerrit.server.account.GroupControl; import com.google.gerrit.server.account.GroupIncludeCache; import com.google.gerrit.server.account.Realm; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.VoidResult; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; import com.google.inject.Provider; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeDetailServiceImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeDetailServiceImpl.java index 875fb4d43c..8090451604 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeDetailServiceImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeDetailServiceImpl.java @@ -22,7 +22,7 @@ import com.google.gerrit.common.data.PatchSetPublishDetail; import com.google.gerrit.reviewdb.client.AccountDiffPreference; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.PatchSet; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.inject.Inject; class ChangeDetailServiceImpl implements ChangeDetailService { diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeManageServiceImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeManageServiceImpl.java index 4178437aac..f99921bd74 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeManageServiceImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeManageServiceImpl.java @@ -17,8 +17,8 @@ package com.google.gerrit.httpd.rpc.changedetail; import com.google.gerrit.common.data.ChangeDetail; import com.google.gerrit.common.data.ChangeManageService; import com.google.gerrit.reviewdb.client.PatchSet; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.VoidResult; import com.google.inject.Inject; class ChangeManageServiceImpl implements ChangeManageService { diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/DeleteDraftChange.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/DeleteDraftChange.java index f55fd1e38f..66c11c0e2a 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/DeleteDraftChange.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/DeleteDraftChange.java @@ -23,7 +23,7 @@ import com.google.gerrit.server.git.GitRepositoryManager; import com.google.gerrit.server.git.ReplicationQueue; import com.google.gerrit.server.project.ChangeControl; import com.google.gerrit.server.project.NoSuchChangeException; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; import com.google.inject.assistedinject.Assisted; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/patch/PatchDetailServiceImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/patch/PatchDetailServiceImpl.java index 5197a7518b..e90467e826 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/patch/PatchDetailServiceImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/patch/PatchDetailServiceImpl.java @@ -46,8 +46,8 @@ import com.google.gerrit.server.patch.PublishComments; import com.google.gerrit.server.project.ChangeControl; import com.google.gerrit.server.project.NoSuchChangeException; import com.google.gerrit.server.workflow.FunctionState; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.VoidResult; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; import com.google.inject.Provider; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/CreateProjectHandler.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/CreateProjectHandler.java index 6afc91f305..039a301fc8 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/CreateProjectHandler.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/CreateProjectHandler.java @@ -22,7 +22,7 @@ import com.google.gerrit.server.project.CreateProject; import com.google.gerrit.server.project.CreateProjectArgs; import com.google.gerrit.server.project.NoSuchProjectException; import com.google.gerrit.server.project.ProjectControl; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import com.google.inject.Inject; import com.google.inject.assistedinject.Assisted; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectAdminServiceImpl.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectAdminServiceImpl.java index ebac67af93..a6bb74fb62 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectAdminServiceImpl.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectAdminServiceImpl.java @@ -22,8 +22,8 @@ import com.google.gerrit.common.data.ProjectDetail; import com.google.gerrit.common.data.ProjectList; import com.google.gerrit.reviewdb.client.Branch; import com.google.gerrit.reviewdb.client.Project; -import com.google.gwt.user.client.rpc.AsyncCallback; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.AsyncCallback; +import com.google.gwtjsonrpc.common.VoidResult; import com.google.inject.Inject; import org.eclipse.jgit.lib.ObjectId; diff --git a/gerrit-openid/pom.xml b/gerrit-openid/pom.xml index 74328cca50..0a39acc422 100644 --- a/gerrit-openid/pom.xml +++ b/gerrit-openid/pom.xml @@ -49,11 +49,6 @@ limitations under the License. org.eclipse.jgit.http.server - - com.google.gwt - gwt-servlet - - org.openid4java openid4java-consumer diff --git a/gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java b/gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java index ee860dfa62..0593bce94f 100644 --- a/gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java +++ b/gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java @@ -30,7 +30,7 @@ import com.google.gerrit.server.config.AuthConfig; import com.google.gerrit.server.config.CanonicalWebUrl; import com.google.gerrit.server.config.ConfigUtil; import com.google.gerrit.server.config.GerritServerConfig; -import com.google.gwt.user.client.rpc.AsyncCallback; +import com.google.gwtjsonrpc.common.AsyncCallback; import com.google.gwtorm.client.KeyUtil; import com.google.inject.Inject; import com.google.inject.Provider; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/ChangeUserName.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/ChangeUserName.java index 0d1d4766b5..d6f45f5cd8 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/ChangeUserName.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/ChangeUserName.java @@ -23,7 +23,7 @@ import com.google.gerrit.reviewdb.client.AccountExternalId; import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.ssh.SshKeyCache; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import com.google.gwtorm.server.OrmDuplicateKeyException; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PublishComments.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PublishComments.java index 34d9d0ea75..17c690f2b1 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PublishComments.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PublishComments.java @@ -36,7 +36,7 @@ import com.google.gerrit.server.project.InvalidChangeOperationException; import com.google.gerrit.server.project.NoSuchChangeException; import com.google.gerrit.server.util.RequestScopePropagator; import com.google.gerrit.server.workflow.FunctionState; -import com.google.gwtjsonrpc.client.VoidResult; +import com.google.gwtjsonrpc.common.VoidResult; import com.google.gwtorm.server.OrmException; import com.google.gwtorm.server.SchemaFactory; import com.google.inject.Inject; diff --git a/pom.xml b/pom.xml index 2520825f52..06ca7d9761 100644 --- a/pom.xml +++ b/pom.xml @@ -48,7 +48,7 @@ limitations under the License. 1.3.0.201202151440-r.75-gff13648 1.4 - 1.2.5 + 1.3 1.2.5 2.3.0 1.6.1