opendev/gerrit
Code Issues Proposed changes

BatchUpdate: Remove protected from static methods

Browse Source 
This modifier is not necessary for the methods to be used by
implementations in the same package.

Change-Id: Iafc1152b48bf9097aa9d7e064b6685036167990a
This commit is contained in:
Dave Borowitz
2017-03-21 08:03:06 -07:00
parent dc84e4acd7
commit 34bc11a6e0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/update/BatchUpdate.java
View File

@@ -117,7 +117,7 @@ public abstract class BatchUpdate implements AutoCloseable {
} }
} }
protected static Order getOrder(Collection<? extends BatchUpdate> updates) { static Order getOrder(Collection<? extends BatchUpdate> updates) {
Order o = null; Order o = null;
for (BatchUpdate u : updates) { for (BatchUpdate u : updates) {
if (o == null) { if (o == null) {
@@ -129,7 +129,7 @@ public abstract class BatchUpdate implements AutoCloseable {
return o; return o;
} }
protected static boolean getUpdateChangesInParallel(Collection<? extends BatchUpdate> updates) { static boolean getUpdateChangesInParallel(Collection<? extends BatchUpdate> updates) {
checkArgument(!updates.isEmpty()); checkArgument(!updates.isEmpty());
Boolean p = null; Boolean p = null;
for (BatchUpdate u : updates) { for (BatchUpdate u : updates) {