Prevent settings URL evaluation before router initialization
The registration dialog makes use of the router's abstracted settings URL independently of any of its configuration. Consequently, the dialog evaluates the URL immediately when instantiated by the gr-app element. Because gr-app initializes the router in its ready lifecycle callback, this evaluation occurs before the router is ready to provide the URL. With this change, the settings URL is evaluated by gr-app after it directly initializes the router, and the resulting string is passed-down into the registration dialog element. Bug: Issue 7837 Change-Id: Ief4daaaa6925f1109487ddb6cee0578e647526d4
This commit is contained in:
@@ -211,6 +211,7 @@ limitations under the License.
|
||||
</gr-overlay>
|
||||
<gr-overlay id="registration" with-backdrop>
|
||||
<gr-registration-dialog
|
||||
settings-url="[[_settingsUrl]]"
|
||||
on-account-detail-update="_handleAccountDetailUpdate"
|
||||
on-close="_handleRegistrationDialogClose">
|
||||
</gr-registration-dialog>
|
||||
|
||||
Reference in New Issue
Block a user