Merge "Treat added reviewers as automated messages"

polygerrit-ui/app/elements/change/gr-message/gr-message.js

@@ -115,7 +115,8 @@
     },
 
     _computeIsAutomated: function(message) {
-      return !!message.tag && message.tag.indexOf('autogenerated') === 0;
+      return !!(message.reviewer ||
+          (message.tag && message.tag.indexOf('autogenerated') === 0));
     },
 
     _computeIsHidden: function(hideAutomated, isAutomated) {

polygerrit-ui/app/elements/change/gr-message/gr-message_test.html

@@ -101,6 +101,21 @@ limitations under the License.
       assert.isTrue(element.hidden);
     });
 
+    test('reviewer message treated as autogenerated', function() {
+      element.message = {
+        tag: 'autogenerated:gerrit:test',
+        updated: '2016-01-12 20:24:49.448000000',
+        reviewer: {},
+      };
+
+      assert.isTrue(element.isAutomated);
+      assert.isFalse(element.hidden);
+
+      element.hideAutomated = true;
+
+      assert.isTrue(element.hidden);
+    });
+
     test('tag that is not autogenerated prefix does not hide', function() {
       element.message = {
         tag: 'something',

polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list.js

@@ -126,8 +126,8 @@
 
     _hasAutomatedMessages: function(messages) {
       for (var i = 0; messages && i < messages.length; i++) {
-        if (messages[i].tag &&
-            messages[i].tag.indexOf('autogenerated') === 0) {
+        if (messages[i].reviewer || (messages[i].tag &&
+            messages[i].tag.indexOf('autogenerated') === 0)) {
           return true;
         }
       }

polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list_test.html

@@ -231,13 +231,18 @@ limitations under the License.
       };
     };
 
+    var randomMessageReviewer = {
+      reviewer: {},
+    };
+
     setup(function() {
       stub('gr-rest-api-interface', {
         getConfig: function() { return Promise.resolve({}); },
         getLoggedIn: function() { return Promise.resolve(false); },
       });
       element = fixture('basic');
-      messages = _.times(3, randomMessage);
+      messages = _.times(2, randomMessage);
+      messages.push(randomMessageReviewer);
       element.messages = messages;
       flushAsynchronousOperations();
     });
@@ -261,11 +266,13 @@ limitations under the License.
 
       element._hideAutomated = false;
       MockInteractions.tap(element.$$('#automatedMessageToggle'));
+      allMessageEls =
+          Polymer.dom(element.root).querySelectorAll('gr-message');
       allHiddenMessageEls =
           Polymer.dom(element.root).querySelectorAll('gr-message[hidden]');
 
-      //Autogenerated messages are now hidden.
-      assert.isTrue(!!allHiddenMessageEls.length);
+      // Autogenerated messages are now hidden.
+      assert.equal(allHiddenMessageEls.length, allMessageEls.length);
     });
 
     test('autogenerated messages are not hidden after clicking show button',