From 35b8e533ae71fdd2ac3404dfd293c79bb6d2857a Mon Sep 17 00:00:00 2001 From: Sasa Zivkov Date: Fri, 18 May 2012 15:57:26 +0200 Subject: [PATCH] Fix guice creation error during plugin loading The loading of of plugin was failing because of double binding of the ServerInformation, once in the PluginModule and once in the Plugin class. Change-Id: I83a2d872814d4b80abb91f2da4e31d3c3f1e7fef Signed-off-by: Sasa Zivkov --- .../java/com/google/gerrit/server/plugins/Plugin.java | 8 -------- 1 file changed, 8 deletions(-) diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/Plugin.java b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/Plugin.java index 81f67aa011..2ed836785d 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/Plugin.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/Plugin.java @@ -20,7 +20,6 @@ import com.google.gerrit.extensions.annotations.PluginData; import com.google.gerrit.extensions.annotations.PluginName; import com.google.gerrit.extensions.registration.RegistrationHandle; import com.google.gerrit.extensions.registration.ReloadableRegistrationHandle; -import com.google.gerrit.extensions.systemstatus.ServerInformation; import com.google.gerrit.lifecycle.LifecycleListener; import com.google.gerrit.lifecycle.LifecycleManager; import com.google.inject.AbstractModule; @@ -174,13 +173,6 @@ public class Plugin { private Injector newRootInjector(PluginGuiceEnvironment env) { List modules = Lists.newArrayListWithCapacity(4); modules.add(env.getSysModule()); - final ServerInformation srvInfo = env.getServerInformation(); - modules.add(new AbstractModule() { - @Override - protected void configure() { - bind(ServerInformation.class).toInstance(srvInfo); - } - }); modules.add(new AbstractModule() { @Override protected void configure() {