opendev/gerrit
Code Issues Proposed changes

Merge "crafting-changes: Add some info on Optional/Nullable" into stable-3.1

Browse Source
This commit is contained in:
Edwin Kempin
2021-02-17 07:24:03 +00:00
committed by Gerrit Code Review
parent 023f19d773 4fefd35a4b
commit 361aecc496
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Documentation/dev-crafting-changes.txt
View File

@@ -159,6 +159,9 @@ run `./tools/setup_gjf.sh` to download a local copy and set up a
wrapper script. If you run your own copy, please use the same version, wrapper script. If you run your own copy, please use the same version,
as there may be slight differences between versions. as there may be slight differences between versions.
[[code-rules]]
== Code Rules
=== Final
When to use `final` modifier and when not (in new code): When to use `final` modifier and when not (in new code):
Always: Always:
@@ -180,6 +183,12 @@ Never:
be removed be removed
* method parameters: similar to local variables * method parameters: similar to local variables
=== Optional / Nullable
Recommended:
* Optionals in arguments are discouraged (use @Nullable instead)
* Return types should be objects or Optionals of objects, but not null/nullable
[[code-organization]] [[code-organization]]
== Code Organization == Code Organization