opendev/gerrit
Code Issues Proposed changes

Merge "Make Code-Review label values' meaning clear to non-maintainers"

Browse Source
This commit is contained in:
Shawn Pearce
2014-01-24 20:43:25 +00:00
committed by Gerrit Code Review
parent 88534997c0 2474e52beb
commit 36fe920c82
4 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/schema/AllProjectsCreator.java
View File

@@ -213,8 +213,8 @@ public class AllProjectsCreator {
new LabelValue((short) 2, "Looks good to me, approved"),
new LabelValue((short) 1, "Looks good to me, but someone else must approve"),
new LabelValue((short) 0, "No score"),
new LabelValue((short) -1, "I would prefer that you didn't submit this"),
new LabelValue((short) -2, "Do not submit")));
new LabelValue((short) -1, "I would prefer this is not merged as is"),
new LabelValue((short) -2, "This shall not be merged")));
type.setAbbreviation("CR");
type.setCopyMinScore(true);
c.getLabelSections().put(type.getName(), type);