opendev/gerrit
Code Issues Proposed changes

FileInfoJsonNewImpl: Fix warning about unneeded else clause

Browse Source 
Statement unnecessarily nested within else clause. The corresponding
then clause does not complete normally

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I3dee2b3b56359119e5792740cffdd3d6366c16bd
This commit is contained in:
Edwin Kempin
2021-02-12 09:31:59 +01:00
parent fd185c7df5
commit 373b966e85
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/com/google/gerrit/server/change/FileInfoJsonNewImpl.java
View File

@@ -48,9 +48,8 @@ public class FileInfoJsonNewImpl implements FileInfoJson {
if (base == null) { if (base == null) {
return asFileInfo( return asFileInfo(
diffs.listModifiedFilesAgainstParent(change.getProject(), objectId, null)); diffs.listModifiedFilesAgainstParent(change.getProject(), objectId, null));
} else {
return asFileInfo(diffs.listModifiedFiles(change.getProject(), base.commitId(), objectId));
} }
return asFileInfo(diffs.listModifiedFiles(change.getProject(), base.commitId(), objectId));
} catch (DiffNotAvailableException e) { } catch (DiffNotAvailableException e) {
convertException(e); convertException(e);
return null; // unreachable. handleAndThrow will throw an exception anyway return null; // unreachable. handleAndThrow will throw an exception anyway