diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/IsReviewedPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/IsReviewedPredicate.java index 97700e71e5..2bf41bb749 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/IsReviewedPredicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/IsReviewedPredicate.java @@ -34,8 +34,8 @@ class IsReviewedPredicate extends IndexPredicate { } PatchSet.Id current = c.currentPatchSetId(); - for (PatchSetApproval p : object.approvals().values()) { - if (p.getPatchSetId().equals(current) && p.getValue() != 0) { + for (PatchSetApproval p : object.approvals().get(current)) { + if (p.getValue() != 0) { return true; } } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerPredicate.java index c697539f46..160656ba1f 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerPredicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerPredicate.java @@ -15,7 +15,6 @@ package com.google.gerrit.server.query.change; import com.google.gerrit.reviewdb.client.Account; -import com.google.gerrit.reviewdb.client.PatchSetApproval; import com.google.gerrit.server.index.ChangeField; import com.google.gerrit.server.index.IndexPredicate; import com.google.gwtorm.server.OrmException; @@ -34,8 +33,8 @@ class ReviewerPredicate extends IndexPredicate { @Override public boolean match(final ChangeData object) throws OrmException { - for (PatchSetApproval p : object.approvals().values()) { - if (id.equals(p.getAccountId())) { + for (Account.Id accountId : object.reviewers().values()) { + if (id.equals(accountId)) { return true; } } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerinPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerinPredicate.java index 58d57c8b33..a29ac62aaf 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerinPredicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerinPredicate.java @@ -14,8 +14,8 @@ package com.google.gerrit.server.query.change; +import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.AccountGroup; -import com.google.gerrit.reviewdb.client.PatchSetApproval; import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.query.OperatorPredicate; @@ -41,9 +41,8 @@ class ReviewerinPredicate extends OperatorPredicate { @Override public boolean match(final ChangeData object) throws OrmException { - for (PatchSetApproval p : object.approvals().values()) { - final IdentifiedUser reviewer = userFactory.create(dbProvider, - p.getAccountId()); + for (Account.Id accountId : object.reviewers().values()) { + IdentifiedUser reviewer = userFactory.create(dbProvider, accountId); if (reviewer.getEffectiveGroups().contains(uuid)) { return true; }