opendev/gerrit
Code Issues Proposed changes

Update git submodules

Browse Source 
* Update plugins/replication from branch 'master'
  to 245389a99e932f1bb08e0f6b684d4a6e581856f3
  - Remove SecureCredentialsProvider, use JGit's UsernamePasswordCredentialsProvider
    
    The SecureCredentialsProvider class actually had nothing to do with the
    user/pass from the secure.config as its name suggests. It was just
    another implementation of a user/pass credentials provider. Since JGit
    already provides a standard implementation,
    UsernamePasswordCredentialsProvider, prefer to use that one.
    
    Change-Id: Iedd196f8bcec15328b4b0c15afe399e3e19bfa70
    
  - Fix CredentialsFactory and CredentialsProvider abstraction leak
    
    The CredentialsFactory returned SecureCredentialsProvider implementation
    class instead of the abstract interface CredentialsProvider.
    
    The SecureCredentialsProvider exposed its getUser and getPass methods
    which were used by the replication plugin and thus hardcoded
    username/password authentication for the REST API based admin
    operations.
    
    Fix the CredentialsFactory to create CredentialsProvider. Remove the
    getUser and getPass methods from the SecureCredentialsProvider. Use the
    abstract CredentialItem to get username and password from the
    CredentialsProvider.
    
    Change-Id: I8b6ef89694db4b7fd6e3116e69f562133f6ad5e8
This commit is contained in:
Saša Živkov
2019-03-19 16:28:23 +01:00
committed by Gerrit Code Review
parent 7a27dac51a
commit 38b659e9d4
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files