Merge "Open all commentlink-specified links in new tabs"

2017-02-17 23:33:13 +00:00
parent cd0c147cfc 78ebe69bfb
commit 391d2ac60e
1 changed files with 7 additions and 0 deletions
--- a/polygerrit-ui/app/elements/shared/gr-linked-text/gr-linked-text.js
+++ b/polygerrit-ui/app/elements/shared/gr-linked-text/gr-linked-text.js
@@ -65,6 +65,13 @@
        }
      }, this.removeZeroWidthSpace);
      parser.parse(content);
+
+      // Ensure that links originating from HTML commentlink configs open in a
+      // new tab. @see Issue 5567
+      output.querySelectorAll('a').forEach(function(anchor) {
+        anchor.setAttribute('target', '_blank');
+        anchor.setAttribute('rel', 'noopener');
+      });
    },
  });
 })();