diff --git a/java/com/google/gerrit/common/data/testing/GroupReferenceSubject.java b/java/com/google/gerrit/common/data/testing/GroupReferenceSubject.java index 265d5901d5..cd96cf4a2f 100644 --- a/java/com/google/gerrit/common/data/testing/GroupReferenceSubject.java +++ b/java/com/google/gerrit/common/data/testing/GroupReferenceSubject.java @@ -40,12 +40,12 @@ public class GroupReferenceSubject extends Subject groupUuid() { isNotNull(); GroupReference group = actual(); - return check("groupUuid()").that(group.getUUID()); + return check("getUUID()").that(group.getUUID()); } public StringSubject name() { isNotNull(); GroupReference group = actual(); - return check("name()").that(group.getName()); + return check("getName()").that(group.getName()); } } diff --git a/java/com/google/gerrit/extensions/common/testing/CommitInfoSubject.java b/java/com/google/gerrit/extensions/common/testing/CommitInfoSubject.java index f0f5516a5e..5da0f7b9f1 100644 --- a/java/com/google/gerrit/extensions/common/testing/CommitInfoSubject.java +++ b/java/com/google/gerrit/extensions/common/testing/CommitInfoSubject.java @@ -41,25 +41,25 @@ public class CommitInfoSubject extends Subject { public StringSubject commit() { isNotNull(); CommitInfo commitInfo = actual(); - return check("commit()").that(commitInfo.commit); + return check("commit").that(commitInfo.commit); } public ListSubject parents() { isNotNull(); CommitInfo commitInfo = actual(); - return check("parents()").about(elements()).thatCustom(commitInfo.parents, commits()); + return check("parents").about(elements()).thatCustom(commitInfo.parents, commits()); } public GitPersonSubject committer() { isNotNull(); CommitInfo commitInfo = actual(); - return check("committer()").about(gitPersons()).that(commitInfo.committer); + return check("committer").about(gitPersons()).that(commitInfo.committer); } public GitPersonSubject author() { isNotNull(); CommitInfo commitInfo = actual(); - return check("author()").about(gitPersons()).that(commitInfo.author); + return check("author").about(gitPersons()).that(commitInfo.author); } public StringSubject message() { diff --git a/java/com/google/gerrit/extensions/common/testing/DiffInfoSubject.java b/java/com/google/gerrit/extensions/common/testing/DiffInfoSubject.java index ee37bde8ee..039991bf0a 100644 --- a/java/com/google/gerrit/extensions/common/testing/DiffInfoSubject.java +++ b/java/com/google/gerrit/extensions/common/testing/DiffInfoSubject.java @@ -39,7 +39,7 @@ public class DiffInfoSubject extends Subject { public ListSubject content() { isNotNull(); DiffInfo diffInfo = actual(); - return check("content()") + return check("content") .about(elements()) .thatCustom(diffInfo.content, ContentEntrySubject.contentEntries()); } @@ -47,18 +47,18 @@ public class DiffInfoSubject extends Subject { public ComparableSubject changeType() { isNotNull(); DiffInfo diffInfo = actual(); - return check("changeType()").that(diffInfo.changeType); + return check("changeType").that(diffInfo.changeType); } public FileMetaSubject metaA() { isNotNull(); DiffInfo diffInfo = actual(); - return check("metaA()").about(fileMetas()).that(diffInfo.metaA); + return check("metaA").about(fileMetas()).that(diffInfo.metaA); } public FileMetaSubject metaB() { isNotNull(); DiffInfo diffInfo = actual(); - return check("metaB()").about(fileMetas()).that(diffInfo.metaB); + return check("metaB").about(fileMetas()).that(diffInfo.metaB); } } diff --git a/java/com/google/gerrit/extensions/common/testing/EditInfoSubject.java b/java/com/google/gerrit/extensions/common/testing/EditInfoSubject.java index 1c99141fdf..8e357c70ea 100644 --- a/java/com/google/gerrit/extensions/common/testing/EditInfoSubject.java +++ b/java/com/google/gerrit/extensions/common/testing/EditInfoSubject.java @@ -46,12 +46,12 @@ public class EditInfoSubject extends Subject { public CommitInfoSubject commit() { isNotNull(); EditInfo editInfo = actual(); - return check("commit()").about(commits()).that(editInfo.commit); + return check("commit").about(commits()).that(editInfo.commit); } public StringSubject baseRevision() { isNotNull(); EditInfo editInfo = actual(); - return check("baseRevision()").that(editInfo.baseRevision); + return check("baseRevision").that(editInfo.baseRevision); } } diff --git a/java/com/google/gerrit/extensions/common/testing/FileInfoSubject.java b/java/com/google/gerrit/extensions/common/testing/FileInfoSubject.java index 3ebf8388d9..82f53deab2 100644 --- a/java/com/google/gerrit/extensions/common/testing/FileInfoSubject.java +++ b/java/com/google/gerrit/extensions/common/testing/FileInfoSubject.java @@ -35,18 +35,18 @@ public class FileInfoSubject extends Subject { public IntegerSubject linesInserted() { isNotNull(); FileInfo fileInfo = actual(); - return check("linesInserted()").that(fileInfo.linesInserted); + return check("linesInserted").that(fileInfo.linesInserted); } public IntegerSubject linesDeleted() { isNotNull(); FileInfo fileInfo = actual(); - return check("linesDeleted()").that(fileInfo.linesDeleted); + return check("linesDeleted").that(fileInfo.linesDeleted); } public ComparableSubject status() { isNotNull(); FileInfo fileInfo = actual(); - return check("status()").that(fileInfo.status); + return check("status").that(fileInfo.status); } } diff --git a/java/com/google/gerrit/extensions/common/testing/FixReplacementInfoSubject.java b/java/com/google/gerrit/extensions/common/testing/FixReplacementInfoSubject.java index 6ba5f8b291..b720d8afa7 100644 --- a/java/com/google/gerrit/extensions/common/testing/FixReplacementInfoSubject.java +++ b/java/com/google/gerrit/extensions/common/testing/FixReplacementInfoSubject.java @@ -40,16 +40,16 @@ public class FixReplacementInfoSubject public StringSubject path() { isNotNull(); - return check("path()").that(actual().path); + return check("path").that(actual().path); } public RangeSubject range() { isNotNull(); - return check("range()").about(ranges()).that(actual().range); + return check("range").about(ranges()).that(actual().range); } public StringSubject replacement() { isNotNull(); - return check("replacement()").that(actual().replacement); + return check("replacement").that(actual().replacement); } } diff --git a/java/com/google/gerrit/extensions/common/testing/FixSuggestionInfoSubject.java b/java/com/google/gerrit/extensions/common/testing/FixSuggestionInfoSubject.java index c5c8270f9d..a5db833786 100644 --- a/java/com/google/gerrit/extensions/common/testing/FixSuggestionInfoSubject.java +++ b/java/com/google/gerrit/extensions/common/testing/FixSuggestionInfoSubject.java @@ -15,7 +15,6 @@ package com.google.gerrit.extensions.common.testing; import static com.google.common.truth.Truth.assertAbout; -import static com.google.common.truth.Truth.assertWithMessage; import static com.google.gerrit.extensions.common.testing.FixReplacementInfoSubject.fixReplacements; import static com.google.gerrit.truth.ListSubject.elements; @@ -42,12 +41,12 @@ public class FixSuggestionInfoSubject extends Subject replacements() { isNotNull(); - return check("replacements()") + return check("replacements") .about(elements()) .thatCustom(actual().replacements, fixReplacements()); } @@ -58,6 +57,6 @@ public class FixSuggestionInfoSubject extends Subject { public StringSubject name() { isNotNull(); GitPerson gitPerson = actual(); - return check("name()").that(gitPerson.name); + return check("name").that(gitPerson.name); } public StringSubject email() { isNotNull(); GitPerson gitPerson = actual(); - return check("email()").that(gitPerson.email); + return check("email").that(gitPerson.email); } public ComparableSubject date() { isNotNull(); GitPerson gitPerson = actual(); - return check("date()").that(gitPerson.date); + return check("date").that(gitPerson.date); } public IntegerSubject tz() { isNotNull(); GitPerson gitPerson = actual(); - return check("tz()").that(gitPerson.tz); + return check("tz").that(gitPerson.tz); } public void hasSameDateAs(GitPerson other) { diff --git a/java/com/google/gerrit/extensions/common/testing/RangeSubject.java b/java/com/google/gerrit/extensions/common/testing/RangeSubject.java index 12acb8d8c7..2b9cec3547 100644 --- a/java/com/google/gerrit/extensions/common/testing/RangeSubject.java +++ b/java/com/google/gerrit/extensions/common/testing/RangeSubject.java @@ -37,19 +37,19 @@ public class RangeSubject extends Subject { } public IntegerSubject startLine() { - return check("startLine()").that(actual().startLine); + return check("startLine").that(actual().startLine); } public IntegerSubject startCharacter() { - return check("startCharacter()").that(actual().startCharacter); + return check("startCharacter").that(actual().startCharacter); } public IntegerSubject endLine() { - return check("endLine()").that(actual().endLine); + return check("endLine").that(actual().endLine); } public IntegerSubject endCharacter() { - return check("endCharacter()").that(actual().endCharacter); + return check("endCharacter").that(actual().endCharacter); } public void isValid() { diff --git a/java/com/google/gerrit/extensions/common/testing/RobotCommentInfoSubject.java b/java/com/google/gerrit/extensions/common/testing/RobotCommentInfoSubject.java index 5e9b45eacd..ed9f97fcc4 100644 --- a/java/com/google/gerrit/extensions/common/testing/RobotCommentInfoSubject.java +++ b/java/com/google/gerrit/extensions/common/testing/RobotCommentInfoSubject.java @@ -45,7 +45,7 @@ public class RobotCommentInfoSubject extends Subject fixSuggestions() { - return check("fixSuggestions()") + return check("fixSuggestions") .about(elements()) .thatCustom(actual().fixSuggestions, FixSuggestionInfoSubject.fixSuggestions()); } diff --git a/java/com/google/gerrit/git/testing/CommitSubject.java b/java/com/google/gerrit/git/testing/CommitSubject.java index 08731072da..e9ba86215a 100644 --- a/java/com/google/gerrit/git/testing/CommitSubject.java +++ b/java/com/google/gerrit/git/testing/CommitSubject.java @@ -68,7 +68,7 @@ public class CommitSubject extends Subject { public void hasCommitMessage(String expectedCommitMessage) { isNotNull(); RevCommit commit = actual(); - check("commitMessage()").that(commit.getFullMessage()).isEqualTo(expectedCommitMessage); + check("getFullMessage()").that(commit.getFullMessage()).isEqualTo(expectedCommitMessage); } /** diff --git a/java/com/google/gerrit/git/testing/ObjectIdSubject.java b/java/com/google/gerrit/git/testing/ObjectIdSubject.java index 5fe91f950d..fb2ee75a4b 100644 --- a/java/com/google/gerrit/git/testing/ObjectIdSubject.java +++ b/java/com/google/gerrit/git/testing/ObjectIdSubject.java @@ -36,6 +36,6 @@ public class ObjectIdSubject extends Subject { public void hasName(String expectedName) { isNotNull(); ObjectId objectId = actual(); - check("name()").that(objectId.getName()).isEqualTo(expectedName); + check("getName()").that(objectId.getName()).isEqualTo(expectedName); } } diff --git a/java/com/google/gerrit/git/testing/PushResultSubject.java b/java/com/google/gerrit/git/testing/PushResultSubject.java index 9aecf68a80..e9d20717f9 100644 --- a/java/com/google/gerrit/git/testing/PushResultSubject.java +++ b/java/com/google/gerrit/git/testing/PushResultSubject.java @@ -49,14 +49,14 @@ public class PushResultSubject extends Subject { public void hasMessages(String... expectedLines) { checkArgument(expectedLines.length > 0, "use hasNoMessages()"); isNotNull(); - check("messages()").that(trimMessages()).isEqualTo(String.join("\n", expectedLines)); + check("trimmedMessages()").that(trimMessages()).isEqualTo(String.join("\n", expectedLines)); } public void containsMessages(String... expectedLines) { checkArgument(expectedLines.length > 0, "use hasNoMessages()"); isNotNull(); Iterable got = Splitter.on("\n").split(trimMessages()); - check("messages()").that(got).containsAtLeastElementsIn(expectedLines).inOrder(); + check("trimmedMessages()").that(got).containsAtLeastElementsIn(expectedLines).inOrder(); } private String trimMessages() { diff --git a/java/com/google/gerrit/proto/testing/SerializedClassSubject.java b/java/com/google/gerrit/proto/testing/SerializedClassSubject.java index 546ff89bf2..09079fddfb 100644 --- a/java/com/google/gerrit/proto/testing/SerializedClassSubject.java +++ b/java/com/google/gerrit/proto/testing/SerializedClassSubject.java @@ -91,7 +91,7 @@ public class SerializedClassSubject extends Subject expectedMethods) { // Would be nice if we could check clazz is an @AutoValue, but the retention is not RUNTIME. isAbstract(); - check("noArgumentAbstractMethodsOn(%s)", actual().getName()) + check("noArgumentAbstractMethods()") .that( Arrays.stream(actual().getDeclaredMethods()) .filter(m -> !Modifier.isStatic(m.getModifiers())) @@ -103,8 +103,6 @@ public class SerializedClassSubject extends Subject groupUuid() { isNotNull(); InternalGroup group = actual(); - return check("groupUuid()").that(group.getGroupUUID()); + return check("getGroupUUID()").that(group.getGroupUUID()); } public ComparableSubject nameKey() { isNotNull(); InternalGroup group = actual(); - return check("nameKey()").that(group.getNameKey()); + return check("getNameKey()").that(group.getNameKey()); } public StringSubject name() { isNotNull(); InternalGroup group = actual(); - return check("name()").that(group.getName()); + return check("getName()").that(group.getName()); } public Subject id() { isNotNull(); InternalGroup group = actual(); - return check("id()").that(group.getId()); + return check("getId()").that(group.getId()); } public StringSubject description() { isNotNull(); InternalGroup group = actual(); - return check("description()").that(group.getDescription()); + return check("getDescription()").that(group.getDescription()); } public ComparableSubject ownerGroupUuid() { isNotNull(); InternalGroup group = actual(); - return check("ownerGroupUuid()").that(group.getOwnerGroupUUID()); + return check("getOwnerGroupUUID()").that(group.getOwnerGroupUUID()); } public BooleanSubject visibleToAll() { isNotNull(); InternalGroup group = actual(); - return check("visibleToAll()").that(group.isVisibleToAll()); + return check("isVisibleToAll()").that(group.isVisibleToAll()); } public ComparableSubject createdOn() { isNotNull(); InternalGroup group = actual(); - return check("createdOn()").that(group.getCreatedOn()); + return check("getCreatedOn()").that(group.getCreatedOn()); } public IterableSubject members() { isNotNull(); InternalGroup group = actual(); - return check("members()").that(group.getMembers()); + return check("getMembers()").that(group.getMembers()); } public IterableSubject subgroups() { isNotNull(); InternalGroup group = actual(); - return check("subgroups()").that(group.getSubgroups()); + return check("getSubgroups()").that(group.getSubgroups()); } public ComparableSubject refState() { isNotNull(); InternalGroup group = actual(); - return check("refState()").that(group.getRefState()); + return check("getRefState()").that(group.getRefState()); } } diff --git a/javatests/com/google/gerrit/server/edit/tree/ChangeFileContentModificationSubject.java b/javatests/com/google/gerrit/server/edit/tree/ChangeFileContentModificationSubject.java index 82b7523ead..0919de9fc4 100644 --- a/javatests/com/google/gerrit/server/edit/tree/ChangeFileContentModificationSubject.java +++ b/javatests/com/google/gerrit/server/edit/tree/ChangeFileContentModificationSubject.java @@ -45,16 +45,16 @@ public class ChangeFileContentModificationSubject public StringSubject filePath() { isNotNull(); - return check("filePath()").that(actual().getFilePath()); + return check("getFilePath()").that(actual().getFilePath()); } public StringSubject newContent() throws IOException { isNotNull(); RawInput newContent = actual().getNewContent(); - check("newContent()").that(newContent).isNotNull(); + check("getNewContent()").that(newContent).isNotNull(); String contentString = CharStreams.toString( new InputStreamReader(newContent.getInputStream(), StandardCharsets.UTF_8)); - return check("newContent()").that(contentString); + return check("getNewContent()").that(contentString); } }