Move file status to a chip at the end of the file name
screenshot: https://imgur.com/a/TWENery Change-Id: I83873a0caf58ba37d7ecad23272ed37ecf93b765
This commit is contained in:
		| @@ -952,6 +952,11 @@ class GrFileList extends mixinBehaviors( [ | |||||||
|     return classes.join(' '); |     return classes.join(' '); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|  |   _computeStatusClass(file) { | ||||||
|  |     const classStr = this._computeClass('status', file.__path); | ||||||
|  |     return `${classStr} ${this._computeFileStatus(file.status)}`; | ||||||
|  |   } | ||||||
|  |  | ||||||
|   _computePathClass(path, expandedFilesRecord) { |   _computePathClass(path, expandedFilesRecord) { | ||||||
|     return this._isFileExpanded(path, expandedFilesRecord) ? 'expanded' : ''; |     return this._isFileExpanded(path, expandedFilesRecord) ? 'expanded' : ''; | ||||||
|   } |   } | ||||||
|   | |||||||
| @@ -26,8 +26,7 @@ export const htmlTemplate = html` | |||||||
|       border-top: 1px solid var(--border-color); |       border-top: 1px solid var(--border-color); | ||||||
|       display: flex; |       display: flex; | ||||||
|       min-height: calc(var(--line-height-normal) + 2 * var(--spacing-s)); |       min-height: calc(var(--line-height-normal) + 2 * var(--spacing-s)); | ||||||
|       padding: var(--spacing-xs) var(--spacing-l) var(--spacing-xs) |       padding: var(--spacing-xs) var(--spacing-l); | ||||||
|         calc(var(--spacing-l) - 0.35rem); |  | ||||||
|     } |     } | ||||||
|     :host(.loading) .row { |     :host(.loading) .row { | ||||||
|       opacity: 0.5; |       opacity: 0.5; | ||||||
| @@ -62,12 +61,31 @@ export const htmlTemplate = html` | |||||||
|       align-items: center; |       align-items: center; | ||||||
|       display: inline-flex; |       display: inline-flex; | ||||||
|     } |     } | ||||||
|     .reviewed, |     .reviewed { | ||||||
|     .status { |  | ||||||
|       display: inline-block; |       display: inline-block; | ||||||
|       text-align: left; |       text-align: left; | ||||||
|       width: 1.5em; |       width: 1.5em; | ||||||
|     } |     } | ||||||
|  |     .status { | ||||||
|  |       display: inline-block; | ||||||
|  |       border-radius: var(--border-radius); | ||||||
|  |       margin-left: var(--spacing-s); | ||||||
|  |       padding: 0 var(--spacing-m); | ||||||
|  |       color: var(--primary-text-color); | ||||||
|  |       font-size: var(--font-size-small); | ||||||
|  |       background-color: var(--dark-add-highlight-color); | ||||||
|  |     } | ||||||
|  |     .status.M { | ||||||
|  |       display: none; | ||||||
|  |     } | ||||||
|  |     .status.D, | ||||||
|  |     .status.R, | ||||||
|  |     .status.W { | ||||||
|  |       background-color: var(--dark-remove-highlight-color); | ||||||
|  |     } | ||||||
|  |     .status.U { | ||||||
|  |       background-color: var(--comment-background-color); | ||||||
|  |     } | ||||||
|     .file-row { |     .file-row { | ||||||
|       cursor: pointer; |       cursor: pointer; | ||||||
|     } |     } | ||||||
| @@ -221,7 +239,8 @@ export const htmlTemplate = html` | |||||||
|       padding: var(--spacing-s) 0; |       padding: var(--spacing-s) 0; | ||||||
|       text-decoration: none; |       text-decoration: none; | ||||||
|     } |     } | ||||||
|     .pathLink:hover { |     .pathLink:hover span.fullFileName, | ||||||
|  |     .pathLink:hover span.truncatedFileName { | ||||||
|       text-decoration: underline; |       text-decoration: underline; | ||||||
|     } |     } | ||||||
|  |  | ||||||
| @@ -231,7 +250,6 @@ export const htmlTemplate = html` | |||||||
|       display: inline-block; |       display: inline-block; | ||||||
|       visibility: hidden; |       visibility: hidden; | ||||||
|       vertical-align: bottom; |       vertical-align: bottom; | ||||||
|       text-decoration: none; |  | ||||||
|       --gr-button: { |       --gr-button: { | ||||||
|         padding: 0px; |         padding: 0px; | ||||||
|       } |       } | ||||||
| @@ -277,7 +295,6 @@ export const htmlTemplate = html` | |||||||
|   </style> |   </style> | ||||||
|   <div id="container" on-click="_handleFileListClick"> |   <div id="container" on-click="_handleFileListClick"> | ||||||
|     <div class="header-row row"> |     <div class="header-row row"> | ||||||
|       <div class="status"></div> |  | ||||||
|       <div class="path">File</div> |       <div class="path">File</div> | ||||||
|       <div class="comments">Comments</div> |       <div class="comments">Comments</div> | ||||||
|       <div class="sizeBars">Size</div> |       <div class="sizeBars">Size</div> | ||||||
| @@ -313,14 +330,6 @@ export const htmlTemplate = html` | |||||||
|           data-file$="[[_computeFileRange(file)]]" |           data-file$="[[_computeFileRange(file)]]" | ||||||
|           tabindex="-1" |           tabindex="-1" | ||||||
|         > |         > | ||||||
|           <div |  | ||||||
|             class$="[[_computeClass('status', file.__path)]]" |  | ||||||
|             tabindex="0" |  | ||||||
|             title$="[[_computeFileStatusLabel(file.status)]]" |  | ||||||
|             aria-label$="[[_computeFileStatusLabel(file.status)]]" |  | ||||||
|           > |  | ||||||
|             [[_computeFileStatus(file.status)]] |  | ||||||
|           </div> |  | ||||||
|           <!-- TODO: Remove data-url as it appears its not used --> |           <!-- TODO: Remove data-url as it appears its not used --> | ||||||
|           <span |           <span | ||||||
|             data-url="[[_computeDiffURL(change, patchRange, file.__path, editMode)]]" |             data-url="[[_computeDiffURL(change, patchRange, file.__path, editMode)]]" | ||||||
| @@ -342,6 +351,14 @@ export const htmlTemplate = html` | |||||||
|               > |               > | ||||||
|                 [[computeTruncatedPath(file.__path)]] |                 [[computeTruncatedPath(file.__path)]] | ||||||
|               </span> |               </span> | ||||||
|  |               <span | ||||||
|  |                 class$="[[_computeStatusClass(file)]]" | ||||||
|  |                 tabindex="0" | ||||||
|  |                 title$="[[_computeFileStatusLabel(file.status)]]" | ||||||
|  |                 aria-label$="[[_computeFileStatusLabel(file.status)]]" | ||||||
|  |               > | ||||||
|  |                 [[_computeFileStatusLabel(file.status)]] | ||||||
|  |               </span> | ||||||
|               <gr-copy-clipboard |               <gr-copy-clipboard | ||||||
|                 hide-input="" |                 hide-input="" | ||||||
|                 text="[[file.__path]]" |                 text="[[file.__path]]" | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 Tao Zhou
					Tao Zhou