opendev/gerrit
Code Issues Proposed changes

Remove multiple implementations of getSshHost() in email classes

Browse Source 
The getSshHost() method was implemented in both ReplacePatchSetSender
and NewChangeSender.

Remove these and implement it in the NotificationEmail base class
instead.

Change-Id: I55e36021915d147e01c676e7837557f5283812f6
This commit is contained in:
Yang Zhenhui
2012-12-21 15:05:36 +08:00
committed by David Pursehouse
parent 618f878dc0
commit 3a495e6c46
5 changed files with 34 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-server/src/main/java/com/google/gerrit/server/mail/CreateChangeSender.java
View File

@@ -40,9 +40,10 @@ public class CreateChangeSender extends NewChangeSender {
@Inject
public CreateChangeSender(EmailArguments ea,
@AnonymousCowardName String anonymousCowardName, SshInfo sshInfo,
@AnonymousCowardName String anonymousCowardName, SshInfo si,
@Assisted Change c) {
super(ea, anonymousCowardName, sshInfo, c);
super(ea, anonymousCowardName, c);
setSshInfo(si);
}
@Override