opendev/gerrit
Code Issues Proposed changes

Improve class naming of group inclusion cache loaders

Browse Source 
In [1] the inner classes were named with lowerCaseNames.
thisIsNotStandard. StandardForClassNamesBeginsWithCaps.

[1] https://gerrit-review.googlesource.com/60356

Change-Id: Ia223cb6f010555841fd00be06c56b880968312fe
(cherry picked from commit b6b88ebe9c)
This commit is contained in:
Shawn Pearce 2014-12-03 14:21:22 -08:00 committed by David Pursehouse
parent 3e032cd61a
commit 3a6d64b460
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gerrit-server/src/main/java/com/google/gerrit/server/account/GroupIncludeCacheImpl.java
View File

@ -53,12 +53,12 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache {
cache(PARENT_GROUPS_NAME,
AccountGroup.UUID.class,
new TypeLiteral<Set<AccountGroup.UUID>>() {})
.loader(parentGroupsLoader.class);
.loader(ParentGroupsLoader.class);
cache(SUBGROUPS_NAME,
AccountGroup.UUID.class,
new TypeLiteral<Set<AccountGroup.UUID>>() {})
.loader(subgroupsLoader.class);
.loader(SubgroupsLoader.class);
cache(EXTERNAL_NAME,
String.class,
@ -133,12 +133,12 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache {
}
}
static class subgroupsLoader extends
static class SubgroupsLoader extends
CacheLoader<AccountGroup.UUID, Set<AccountGroup.UUID>> {
private final SchemaFactory<ReviewDb> schema;
@Inject
subgroupsLoader(final SchemaFactory<ReviewDb> sf) {
SubgroupsLoader(final SchemaFactory<ReviewDb> sf) {
schema = sf;
}
@ -163,12 +163,12 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache {
}
}
static class parentGroupsLoader extends
static class ParentGroupsLoader extends
CacheLoader<AccountGroup.UUID, Set<AccountGroup.UUID>> {
private final SchemaFactory<ReviewDb> schema;
@Inject
parentGroupsLoader(final SchemaFactory<ReviewDb> sf) {
ParentGroupsLoader(final SchemaFactory<ReviewDb> sf) {
schema = sf;
}