diff --git a/gerrit-lucene/src/main/java/com/google/gerrit/lucene/QueryBuilder.java b/gerrit-lucene/src/main/java/com/google/gerrit/lucene/QueryBuilder.java index 7fd98aa84f..939c1fbccc 100644 --- a/gerrit-lucene/src/main/java/com/google/gerrit/lucene/QueryBuilder.java +++ b/gerrit-lucene/src/main/java/com/google/gerrit/lucene/QueryBuilder.java @@ -82,11 +82,11 @@ public class QueryBuilder { private Query or(Predicate p) throws QueryParseException { try { - BooleanQuery q = new BooleanQuery(); + BooleanQuery.Builder q = new BooleanQuery.Builder(); for (int i = 0; i < p.getChildCount(); i++) { q.add(toQuery(p.getChild(i)), SHOULD); } - return q; + return q.build(); } catch (BooleanQuery.TooManyClauses e) { throw new QueryParseException("cannot create query for index: " + p, e); } @@ -95,7 +95,7 @@ public class QueryBuilder { private Query and(Predicate p) throws QueryParseException { try { - BooleanQuery b = new BooleanQuery(); + BooleanQuery.Builder b = new BooleanQuery.Builder(); List not = Lists.newArrayListWithCapacity(p.getChildCount()); for (int i = 0; i < p.getChildCount(); i++) { Predicate c = p.getChild(i); @@ -113,7 +113,7 @@ public class QueryBuilder { for (Query q : not) { b.add(q, MUST_NOT); } - return b; + return b.build(); } catch (BooleanQuery.TooManyClauses e) { throw new QueryParseException("cannot create query for index: " + p, e); } @@ -127,10 +127,10 @@ public class QueryBuilder { } // Lucene does not support negation, start with all and subtract. - BooleanQuery q = new BooleanQuery(); - q.add(new MatchAllDocsQuery(), MUST); - q.add(toQuery(n), MUST_NOT); - return q; + return new BooleanQuery.Builder() + .add(new MatchAllDocsQuery(), MUST) + .add(toQuery(n), MUST_NOT) + .build(); } private Query fieldQuery(IndexPredicate p) diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerSuggestionCache.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerSuggestionCache.java index 093506c77f..fa9ea4d932 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerSuggestionCache.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerSuggestionCache.java @@ -107,16 +107,16 @@ public class ReviewerSuggestionCache { List segments = Splitter.on(' ').omitEmptyStrings().splitToList( query.toLowerCase()); - BooleanQuery q = new BooleanQuery(); + BooleanQuery.Builder q = new BooleanQuery.Builder(); for (String field : ALL) { - BooleanQuery and = new BooleanQuery(); + BooleanQuery.Builder and = new BooleanQuery.Builder(); for (String s : segments) { and.add(new PrefixQuery(new Term(field, s)), Occur.MUST); } - q.add(and, Occur.SHOULD); + q.add(and.build(), Occur.SHOULD); } - TopDocs results = searcher.search(q, n); + TopDocs results = searcher.search(q.build(), n); ScoreDoc[] hits = results.scoreDocs; List result = new LinkedList<>(); diff --git a/lib/lucene/BUCK b/lib/lucene/BUCK index 5e4a82f33f..c5107d53d2 100644 --- a/lib/lucene/BUCK +++ b/lib/lucene/BUCK @@ -1,6 +1,6 @@ include_defs('//lib/maven.defs') -VERSION = '5.2.1' +VERSION = '5.3.0' # core and backward-codecs both provide # META-INF/services/org.apache.lucene.codecs.Codec, so they must be merged. @@ -16,7 +16,7 @@ merge_maven_jars( maven_jar( name = 'core_jar', id = 'org.apache.lucene:lucene-core:' + VERSION, - sha1 = 'a175590aa8b04e079eb1a136fd159f9163482ba4', + sha1 = '9e12bb7c39e964a544e3a23b9c8ffa9599d38f10', license = 'Apache2.0', exclude = [ 'META-INF/LICENSE.txt', @@ -28,7 +28,7 @@ maven_jar( maven_jar( name = 'analyzers-common', id = 'org.apache.lucene:lucene-analyzers-common:' + VERSION, - sha1 = '33b7cc17d5a7c939af6fe3f67563f4709926d7f5', + sha1 = '1502beac94cf437baff848ffbbb8f76172befa6b', license = 'Apache2.0', deps = [':core-and-backward-codecs'], exclude = [ @@ -40,7 +40,7 @@ maven_jar( maven_jar( name = 'backward-codecs_jar', id = 'org.apache.lucene:lucene-backward-codecs:' + VERSION, - sha1 = '603d1f06b133449272799d698e5118db65e523ba', + sha1 = 'f654901e55fe56bdbe4be202767296929c2f8d9e', license = 'Apache2.0', deps = [':core_jar'], exclude = [ @@ -53,7 +53,7 @@ maven_jar( maven_jar( name = 'misc', id = 'org.apache.lucene:lucene-misc:' + VERSION, - sha1 = 'be0a4f0ac06f0a2fa3689b4bf6cd1fe6847f9969', + sha1 = 'd03ce6d1bb8ab3926b3acc717418c474a49ade69', license = 'Apache2.0', deps = [':core-and-backward-codecs'], exclude = [ @@ -65,7 +65,7 @@ maven_jar( maven_jar( name = 'queryparser', id = 'org.apache.lucene:lucene-queryparser:' + VERSION, - sha1 = '73be0a2d4ab3e6b574be1938bfb27f7f730f0ad9', + sha1 = '2c5e08580316c90b56a52e3cb686e1cf69db3f9e', license = 'Apache2.0', deps = [':core-and-backward-codecs'], exclude = [