From 3b4ca73c2c70b125b46a55d293c0db592d15d2bf Mon Sep 17 00:00:00 2001 From: Shawn Pearce Date: Thu, 23 May 2013 10:45:51 -0700 Subject: [PATCH] Fix download and download_sources to aggressively get all targets Run any target that depends on download_file, no matter what its name is. This allows grabbing codemirror without confusing the __download_bin case with assuming a __download_src target exists. Change-Id: Iaf7cc3000164aa46376314f8d24dc1f057ab06c3 --- lib/codemirror/BUCK | 4 ++-- tools/download_all.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/codemirror/BUCK b/lib/codemirror/BUCK index 5c64335c2c..0f2d3131f7 100644 --- a/lib/codemirror/BUCK +++ b/lib/codemirror/BUCK @@ -16,7 +16,7 @@ genrule( ]), srcs = [genfile('codemirror-' + VERSION + '.zip')], deps = [ - ':codemirror__download_bin', + ':download', '//lib:LICENSE-codemirror', ], out = 'codemirror.jar', @@ -24,7 +24,7 @@ genrule( ) genrule( - name = 'codemirror__download_bin', + name = 'download', cmd = '${//tools:download_file}' + ' -o $OUT' + ' -u ' + URL + diff --git a/tools/download_all.py b/tools/download_all.py index 7be8e122fb..241d20b75c 100755 --- a/tools/download_all.py +++ b/tools/download_all.py @@ -18,7 +18,7 @@ import re from subprocess import check_call, CalledProcessError, Popen, PIPE MAIN = ['//tools/eclipse:classpath'] -PAT = re.compile(r'"(//.*?__download_[^"]*)" -> "//tools:download_file"') +PAT = re.compile(r'"(//.*?)" -> "//tools:download_file"') opts = OptionParser() opts.add_option('--src', action='store_true')