Merge branch 'stable-3.1'

* stable-3.1:
  Bazel: Remove unused polygerrit-ui/app:bower_components rule
  Bazel: Make maven_jar rule forward compatible
  Bazel: Replace deprecated dependency mode LOOSE with PRUNE_LEGACY
  Fix parse error from repo settings page
  Replace 'Menlo' with 'SF Mono'
  `shift+r` should only be triggered on `keyup`
  Wrap file names into multiple lines if its too long

Change-Id: I471f80f059520105dd12f27021d334b697d89229
This commit is contained in:
David Ostrovsky 2019-12-24 21:32:28 +01:00
commit 3bd799538f
5 changed files with 5 additions and 13 deletions

View File

@ -61,17 +61,6 @@ filegroup(
),
)
filegroup(
name = "bower_components",
srcs = glob(
[
"bower_components/**/*.html",
"bower_components/**/*.js",
"bower_components/**/*.js.map",
],
),
)
genrule2(
name = "pg_code_zip",
srcs = [":pg_code"],

View File

@ -76,9 +76,9 @@
}
/**
* @param {?boolean} value - fallback to false if undefined
* @param {string} value - fallback to 'false' if undefined
*/
_computeChecked(value = false) {
_computeChecked(value = 'false') {
return JSON.parse(value);
}

View File

@ -19,6 +19,7 @@ def polygerrit_bundle(name, srcs, outs, app):
],
language = "ECMASCRIPT_2017",
deps = [name + "_closure_lib"],
dependency_mode = "PRUNE_LEGACY",
)
# TODO(davido): Remove JSC_REFERENCE_BEFORE_DECLARE when this is fixed upstream:

View File

@ -494,6 +494,7 @@ def polygerrit_plugin(name, app, srcs = [], deps = [], externs = [], assets = No
deps = [
name + "_closure_lib",
],
dependency_mode = "PRUNE_LEGACY",
)
if html_plugin:

View File

@ -94,6 +94,7 @@ def _generate_build_files(ctx, binjar, srcjar):
srcjar_attr = 'srcjar = "%s",' % srcjar
contents = """
{header}
load("@rules_java//java:defs.bzl", "java_import")
package(default_visibility = ['//visibility:public'])
java_import(
name = 'jar',