Change "a SQL" to "an SQL"
Change-Id: I7521bd44e689a294433488db4a4ba4c9f310d20f
This commit is contained in:
@@ -66,7 +66,7 @@ original namesake of Rietveld, Gerrit Rietveld, a Dutch architect.
|
|||||||
|
|
||||||
Gerrit 2.x is a complete rewrite of the Gerrit fork, completely
|
Gerrit 2.x is a complete rewrite of the Gerrit fork, completely
|
||||||
changing the implementation from Python on Google App Engine, to Java
|
changing the implementation from Python on Google App Engine, to Java
|
||||||
on a J2EE servlet container and a SQL database.
|
on a J2EE servlet container and an SQL database.
|
||||||
|
|
||||||
* link:http://video.google.com/videoplay?docid=-8502904076440714866[Mondrian Code Review On The Web]
|
* link:http://video.google.com/videoplay?docid=-8502904076440714866[Mondrian Code Review On The Web]
|
||||||
* link:http://code.google.com/p/rietveld/[Rietveld - Code Review for Subversion]
|
* link:http://code.google.com/p/rietveld/[Rietveld - Code Review for Subversion]
|
||||||
|
@@ -1,7 +1,7 @@
|
|||||||
Gerrit Code Review - Developer Setup
|
Gerrit Code Review - Developer Setup
|
||||||
====================================
|
====================================
|
||||||
|
|
||||||
Apache Maven or Facebook Buck is needed to compile the code, and a
|
Apache Maven or Facebook Buck is needed to compile the code, and an
|
||||||
SQL database to house the review metadata. H2 is recommended for
|
SQL database to house the review metadata. H2 is recommended for
|
||||||
development databases, as it requires no external server process.
|
development databases, as it requires no external server process.
|
||||||
|
|
||||||
|
@@ -9,7 +9,7 @@ the host:
|
|||||||
|
|
||||||
* JDK, minimum version 1.6 http://www.oracle.com/technetwork/java/javase/downloads/index.html[Download]
|
* JDK, minimum version 1.6 http://www.oracle.com/technetwork/java/javase/downloads/index.html[Download]
|
||||||
|
|
||||||
You'll also need a SQL database to house the review metadata. You have the
|
You'll also need an SQL database to house the review metadata. You have the
|
||||||
choice of either using the embedded H2 or to host your own MySQL or PostgreSQL.
|
choice of either using the embedded H2 or to host your own MySQL or PostgreSQL.
|
||||||
|
|
||||||
|
|
||||||
|
@@ -117,7 +117,7 @@ Bug Fixes
|
|||||||
---------
|
---------
|
||||||
* GERRIT-5 Remove PatchSetInfo from database and get it always fr...
|
* GERRIT-5 Remove PatchSetInfo from database and get it always fr...
|
||||||
+
|
+
|
||||||
A very, very old bug. We no longer mirror the commit data into the SQL database, but instead pull it directly from Git when needed. Removing duplicated data simplifies the data store model, something that is important as we shift from a SQL database to a Git backed database.
|
A very, very old bug. We no longer mirror the commit data into the SQL database, but instead pull it directly from Git when needed. Removing duplicated data simplifies the data store model, something that is important as we shift from an SQL database to a Git backed database.
|
||||||
|
|
||||||
* GERRIT-220 Fix infinite loop in PatchScriptBuilder
|
* GERRIT-220 Fix infinite loop in PatchScriptBuilder
|
||||||
+
|
+
|
||||||
@@ -314,4 +314,4 @@ This release is really massive because the internal code moved from some really
|
|||||||
* Cleanup display of external ids in the user settings
|
* Cleanup display of external ids in the user settings
|
||||||
* Preserve negative approvals when replacing patch sets
|
* Preserve negative approvals when replacing patch sets
|
||||||
* Use gwtjsonrpc 1.1.1
|
* Use gwtjsonrpc 1.1.1
|
||||||
* gerrit 2.0.18
|
* gerrit 2.0.18
|
||||||
|
@@ -118,7 +118,7 @@ SSH usernames were permitted to contain any character, including
|
|||||||
oddball characters like '\0' and '/'. We really want them to
|
oddball characters like '\0' and '/'. We really want them to
|
||||||
be a restricted subset which won't cause errors when we try to
|
be a restricted subset which won't cause errors when we try to
|
||||||
map SSH usernames as file names in a Git repository as we try
|
map SSH usernames as file names in a Git repository as we try
|
||||||
to move away from a SQL database.
|
to move away from an SQL database.
|
||||||
|
|
||||||
* GERRIT-282 Fix reply to comment on left side
|
* GERRIT-282 Fix reply to comment on left side
|
||||||
+
|
+
|
||||||
@@ -157,4 +157,4 @@ Other Changes
|
|||||||
* GERRIT-67 Wait for dependencies to submit before claiming merge ...
|
* GERRIT-67 Wait for dependencies to submit before claiming merge ...
|
||||||
* Move abandonChange to ChangeManageService
|
* Move abandonChange to ChangeManageService
|
||||||
* Remove trailing whitespace in install.txt
|
* Remove trailing whitespace in install.txt
|
||||||
* Gerrit 2.0.22
|
* Gerrit 2.0.22
|
||||||
|
@@ -147,7 +147,7 @@ public abstract class SchemaVersion {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Execute a SQL statement. */
|
/** Execute an SQL statement. */
|
||||||
protected void execute(ReviewDb db, String sql) throws SQLException {
|
protected void execute(ReviewDb db, String sql) throws SQLException {
|
||||||
Statement s = ((JdbcSchema) db).getConnection().createStatement();
|
Statement s = ((JdbcSchema) db).getConnection().createStatement();
|
||||||
try {
|
try {
|
||||||
|
@@ -28,7 +28,7 @@ import java.sql.Statement;
|
|||||||
import java.util.ArrayList;
|
import java.util.ArrayList;
|
||||||
import java.util.List;
|
import java.util.List;
|
||||||
|
|
||||||
/** Parses a SQL script from a resource file and later runs it. */
|
/** Parses an SQL script from a resource file and later runs it. */
|
||||||
class ScriptRunner {
|
class ScriptRunner {
|
||||||
private final String name;
|
private final String name;
|
||||||
private final List<String> commands;
|
private final List<String> commands;
|
||||||
|
Reference in New Issue
Block a user