opendev/gerrit
Code Issues Proposed changes

Use QueryProjects#apply without parameters

Browse Source 
The apply(TopLevelResource) method doesn't actually use the given
resource parameter, and only exists to satisfy the interface of its
parent RestReadView.

A variant of the method without the TopLevelResource parameter was
added in change Ia8ded07a5. Modify callers to use that.

Change-Id: I15af0d1cb35750c8aec4b2f42339901c48332889
This commit is contained in:
David Pursehouse
2019-02-08 13:30:42 +09:00
parent d3b45a59f2
commit 3c52bf9f63
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/com/google/gerrit/server/restapi/project/ListChildProjects.java
View File

@@ -21,7 +21,6 @@ import com.google.gerrit.extensions.restapi.BadRequestException;
import com.google.gerrit.extensions.restapi.ResourceConflictException;
import com.google.gerrit.extensions.restapi.RestApiException;
import com.google.gerrit.extensions.restapi.RestReadView;
import com.google.gerrit.extensions.restapi.TopLevelResource;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.server.permissions.PermissionBackend;
import com.google.gerrit.server.permissions.PermissionBackendException;
@@ -90,7 +89,7 @@ public class ListChildProjects implements RestReadView<ProjectResource> {
.get()
.withQuery("parent:" + parent.get())
.withLimit(limit)
.apply(TopLevelResource.INSTANCE)
.apply()
.stream()
.filter(
p ->