opendev/gerrit
Code Issues Proposed changes

Fix: NPE when editing topic name of change uploaded without topic

Browse Source 
If a change is uploaded for review without specifying a topic name,
the topic field in the change record is null.  This causes a Null
Pointer Exception when attempting to compare the old topic name with
the new one.

Add a check to initialise the topic name to empty string if it is
null.

Change-Id: Iae95bf78f87c1af181db327770f74a514258ced5
This commit is contained in:
David Pursehouse
2012-11-16 18:42:51 +09:00
parent 02688686b5
commit 3d45206d1c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/changedetail/AlterTopic.java
View File

@@ -93,7 +93,7 @@ public class AlterTopic implements Callable<ReviewResult> {
}
final Change change = db.changes().get(changeId);
final String oldTopicName = change.getTopic();
final String oldTopicName = change.getTopic() != null ? change.getTopic() : "";
if (!oldTopicName.equals(newTopicName)) {
String summary;
if (oldTopicName.isEmpty()) {