diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js index 708a730c01..0ce6225465 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js +++ b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js @@ -226,6 +226,7 @@ _computeItemNeedsReview(account, change, showReviewedState) { return showReviewedState && !change.reviewed && + !change.work_in_progress && this.changeIsOpen(change.status) && (!account || account._account_id != change.owner._account_id); }, diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list_test.html b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list_test.html index d20d40a9b3..d5b9aa96b3 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list_test.html +++ b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list_test.html @@ -231,11 +231,17 @@ limitations under the License. status: 'ABANDONED', owner: {_account_id: 0}, }, + { + _number: 4, + status: 'NEW', + work_in_progress: true, + owner: {_account_id: 0}, + }, ]; flushAsynchronousOperations(); let elementItems = Polymer.dom(element.root).querySelectorAll( 'gr-change-list-item'); - assert.equal(elementItems.length, 4); + assert.equal(elementItems.length, 5); for (let i = 0; i < elementItems.length; i++) { assert.isFalse(elementItems[i].hasAttribute('needs-review')); } @@ -243,20 +249,22 @@ limitations under the License. element.showReviewedState = true; elementItems = Polymer.dom(element.root).querySelectorAll( 'gr-change-list-item'); - assert.equal(elementItems.length, 4); + assert.equal(elementItems.length, 5); assert.isFalse(elementItems[0].hasAttribute('needs-review')); assert.isTrue(elementItems[1].hasAttribute('needs-review')); assert.isFalse(elementItems[2].hasAttribute('needs-review')); assert.isFalse(elementItems[3].hasAttribute('needs-review')); + assert.isFalse(elementItems[4].hasAttribute('needs-review')); element.account = {_account_id: 42}; elementItems = Polymer.dom(element.root).querySelectorAll( 'gr-change-list-item'); - assert.equal(elementItems.length, 4); + assert.equal(elementItems.length, 5); assert.isFalse(elementItems[0].hasAttribute('needs-review')); assert.isTrue(elementItems[1].hasAttribute('needs-review')); assert.isFalse(elementItems[2].hasAttribute('needs-review')); assert.isFalse(elementItems[3].hasAttribute('needs-review')); + assert.isFalse(elementItems[4].hasAttribute('needs-review')); }); test('no changes', () => {