opendev/gerrit
Code Issues Proposed changes

Merge "Add acceptance test for granting global capabilities"

Browse Source
This commit is contained in:
Shawn Pearce
2013-11-09 01:19:42 +00:00
committed by Gerrit Code Review
parent bee7102610 edb57bbf3d
commit 3e2403d0a4
3 changed files with 195 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/account/BUCK
View File

@@ -7,7 +7,11 @@ acceptance_tests(
java_library(
name = 'util',
srcs = ['AccountAssert.java', 'AccountInfo.java'],
srcs = [
'AccountAssert.java',
'AccountInfo.java',
'CapabilityInfo.java',
],
deps = [
'//gerrit-acceptance-tests:lib',
'//gerrit-reviewdb:server',

150
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/account/CapabilitiesIT.java Normal file
View File

@@ -0,0 +1,150 @@
// Copyright (C) 2013 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.acceptance.rest.account;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import com.google.gerrit.acceptance.AbstractDaemonTest;
import com.google.gerrit.acceptance.AccountCreator;
import com.google.gerrit.acceptance.RestResponse;
import com.google.gerrit.acceptance.RestSession;
import com.google.gerrit.acceptance.TestAccount;
import com.google.gerrit.common.data.AccessSection;
import com.google.gerrit.common.data.GlobalCapability;
import com.google.gerrit.common.data.Permission;
import com.google.gerrit.common.data.PermissionRule;
import com.google.gerrit.reviewdb.client.AccountGroup;
import com.google.gerrit.server.account.GroupCache;
import com.google.gerrit.server.config.AllProjectsName;
import com.google.gerrit.server.git.MetaDataUpdate;
import com.google.gerrit.server.git.ProjectConfig;
import com.google.gerrit.server.project.ProjectCache;
import com.google.gson.Gson;
import com.google.gson.reflect.TypeToken;
import com.google.inject.Inject;
import org.eclipse.jgit.errors.ConfigInvalidException;
import org.junit.Before;
import org.junit.Test;
import java.io.IOException;
public class CapabilitiesIT extends AbstractDaemonTest {
@Inject
private AccountCreator accounts;
@Inject
private AllProjectsName allProjects;
@Inject
private MetaDataUpdate.Server metaDataUpdateFactory;
@Inject
private GroupCache groupCache;
@Inject
private ProjectCache projectCache;
private RestSession userSession;
private RestSession adminSession;
@Before
public void setUp() throws Exception {
TestAccount user = accounts.create("user", "user@example.com", "User");
TestAccount admin = accounts.admin();
userSession = new RestSession(server, user);
adminSession = new RestSession(server, admin);
}
@Test
public void testCapabilitiesUser() throws IOException,
ConfigInvalidException, IllegalArgumentException,
IllegalAccessException, NoSuchFieldException,
SecurityException {
grantAllCapabilities();
RestResponse r =
userSession.get("/accounts/self/capabilities");
int code = r.getStatusCode();
assertEquals(code, 200);
CapabilityInfo info = (new Gson()).fromJson(r.getReader(),
new TypeToken<CapabilityInfo>() {}.getType());
for (String c: GlobalCapability.getAllNames()) {
if (GlobalCapability.ADMINISTRATE_SERVER.equals(c)) {
assertFalse(info.administrateServer);
} else if (GlobalCapability.PRIORITY.equals(c)) {
assertFalse(info.priority);
} else if (GlobalCapability.QUERY_LIMIT.equals(c)) {
assertEquals(0, info.queryLimit.min);
assertEquals(0, info.queryLimit.max);
} else {
assertTrue(String.format("capability %s was not granted", c),
(Boolean)CapabilityInfo.class.getField(c).get(info));
}
}
}
@Test
public void testCapabilitiesAdmin() throws IOException,
ConfigInvalidException, IllegalArgumentException,
IllegalAccessException, NoSuchFieldException,
SecurityException {
RestResponse r =
adminSession.get("/accounts/self/capabilities");
int code = r.getStatusCode();
assertEquals(code, 200);
CapabilityInfo info = (new Gson()).fromJson(r.getReader(),
new TypeToken<CapabilityInfo>() {}.getType());
for (String c: GlobalCapability.getAllNames()) {
if (GlobalCapability.PRIORITY.equals(c)) {
assertFalse(info.priority);
} else if (GlobalCapability.QUERY_LIMIT.equals(c)) {
assertEquals(0, info.queryLimit.min);
assertEquals(500, info.queryLimit.max);
} else if (GlobalCapability.ACCESS_DATABASE.equals(c)) {
assertFalse(info.accessDatabase);
} else if (GlobalCapability.RUN_AS.equals(c)) {
assertFalse(info.runAs);
} else {
assertTrue(String.format("capability %s was not granted", c),
(Boolean)CapabilityInfo.class.getField(c).get(info));
}
}
}
private void grantAllCapabilities() throws IOException,
ConfigInvalidException {
MetaDataUpdate md = metaDataUpdateFactory.create(allProjects);
md.setMessage("Make super user");
ProjectConfig config = ProjectConfig.read(md);
AccessSection s = config.getAccessSection(
AccessSection.GLOBAL_CAPABILITIES);
for (String c: GlobalCapability.getAllNames()) {
if (GlobalCapability.ADMINISTRATE_SERVER.equals(c)) {
continue;
}
Permission p = s.getPermission(c, true);
AccountGroup projectOwnersGroup = groupCache.get(
new AccountGroup.NameKey("Registered Users"));
PermissionRule rule = new PermissionRule(
config.resolve(projectOwnersGroup));
p.add(rule);
}
config.commit(md);
projectCache.evict(config.getProject());
}
}

40
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/account/CapabilityInfo.java Normal file
View File

@@ -0,0 +1,40 @@
// Copyright (C) 2013 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.acceptance.rest.account;
class CapabilityInfo {
public boolean accessDatabase;
public boolean administrateServer;
public boolean createAccount;
public boolean createGroup;
public boolean createProject;
public boolean emailReviewers;
public boolean flushCaches;
public boolean generateHttpPassword;
public boolean killTask;
public boolean priority;
public QueryLimit queryLimit;
public boolean runAs;
public boolean runGC;
public boolean streamEvents;
public boolean viewCaches;
public boolean viewConnections;
public boolean viewQueue;
static class QueryLimit {
short min;
short max;
}
}