opendev/gerrit
Code Issues Proposed changes

Remove unused .html file from shared components

Browse Source 
You can import .js files instead of .html files

Change-Id: Ied0c5b00f2915d2a27b54756edf7b37f73b7fc88
This commit is contained in:
Dmitrii Filippov
2020-03-23 19:45:16 +01:00
parent e7a1d8c9f5
commit 3e5ba3bbd8
3 changed files with 2 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/embed/README.md
View File

@@ -2,7 +2,7 @@ This folder contains shared components that can be used independently from Gerri
### gr-diff ### gr-diff
`gr-diff.html` is the `gr-diff` component used in gerrit to render diff. If you want to use it, feel free to import it and use it in your project as: `gr-diff.js` is the `gr-diff` component used in gerrit to render diff. If you want to use it, feel free to import it and use it in your project as:
``` ```
<gr-diff></gr-diff> <gr-diff></gr-diff>
@@ -10,4 +10,4 @@ This folder contains shared components that can be used independently from Gerri
All supported attributes defined in `polygerrit-ui/app/elements/diff/gr-diff/gr-diff.js`, you can pass them by just assigning them to the `gr-app` element. All supported attributes defined in `polygerrit-ui/app/elements/diff/gr-diff/gr-diff.js`, you can pass them by just assigning them to the `gr-app` element.
To customize the style of the diff, you can use `css variables`, all supported varibled defined in `polygerrit-ui/app/styles/themes/app-theme.html` and `polygerrit-ui/app/styles/themes/dark-theme.html`. To customize the style of the diff, you can use `css variables`, all supported varibled defined in `polygerrit-ui/app/styles/themes/app-theme.html` and `polygerrit-ui/app/styles/themes/dark-theme.html`.

18
polygerrit-ui/app/embed/gr-diff.html
View File

@@ -1,18 +0,0 @@
<!--
@license
Copyright (C) 2019 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<script type="module" src="./gr-diff.js"> </script>

18
polygerrit-ui/app/gr-diff/gr-diff-root.html
View File

@@ -1,18 +0,0 @@
<!--
@license
Copyright (C) 2020 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<script type="module" src="./gr-diff-root.js"></script>