Make AccountState an AutoValue

AccountState is a cached entity that is shared between different
threads. We therefore want it to be immutable. AutoValue is the
preferred way of generating immutable entities that have equals and
toString implementations and is used for almost all other caches. Hence,
we use it for AccountState too.

Change-Id: I3b19ef34791c8800667fdcf9ad8beade8539af13
This commit is contained in:
Patrick Hiesel
2019-08-07 15:25:07 +02:00
parent a5dd85e5d2
commit 3e64fd492b
82 changed files with 253 additions and 278 deletions

View File

@@ -234,7 +234,7 @@ public class IdentifiedUser extends CurrentUser {
groupBackend,
enableReverseDnsLookup,
remotePeerProvider,
state.getAccount().id(),
state.account().id(),
realUser);
this.state = state;
}
@@ -323,7 +323,7 @@ public class IdentifiedUser extends CurrentUser {
*/
@Override
public Optional<String> getUserName() {
return state().getUserName();
return state().userName();
}
/** @return unique name of the user for logging, never {@code null} */
@@ -339,7 +339,7 @@ public class IdentifiedUser extends CurrentUser {
* @return the account of the identified user, an empty account if the account is missing
*/
public Account getAccount() {
return state().getAccount();
return state().account();
}
public boolean hasEmailAddress(String email) {
@@ -376,7 +376,7 @@ public class IdentifiedUser extends CurrentUser {
@Override
public GroupMembership getEffectiveGroups() {
if (effectiveGroups == null) {
if (authConfig.isIdentityTrustable(state().getExternalIds())) {
if (authConfig.isIdentityTrustable(state().externalIds())) {
effectiveGroups = groupBackend.membershipsOf(this);
logger.atFinest().log(
"Known groups of %s: %s", getLoggableName(), lazy(effectiveGroups::getKnownGroups));