opendev/gerrit
Code Issues Proposed changes

Polymer 2: Add _legacyUndefinedCheck

Browse Source 
When legacy-data-mixin.html is imported this will tell you on the console which observers need fixing regarding this change of behavior:

https://polymer-library.polymer-project.org/2.0/docs/upgrade#update-observers

This change was created by running this command line:

find polygerrit-ui/app/ -type f | xargs sed -i '/^    is: / a\    _legacyUndefinedCheck: true,'

Once all observers are fixed, this change will be reverted. This is tracked in https://bugs.chromium.org/p/gerrit/issues/detail?id=10723

Change-Id: Icccdfaa52bf77dfb25e949b2aa2402110f6c2276
This commit is contained in:
brohlfs
2019-04-11 10:56:21 +02:00
committed by Ben Rohlfs
parent 6aa82ec016
commit 3e7f5fdd3f
181 changed files with 181 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
polygerrit-ui/app/elements/shared/gr-comment-thread/gr-comment-thread.js
View File

@@ -22,6 +22,7 @@
Polymer({
is: 'gr-comment-thread',
_legacyUndefinedCheck: true,
/**
* Fired when the thread should be discarded.