opendev/gerrit
Code Issues Proposed changes

Improve description of auth.skipFullRefEvaluationIfAllRefsAreVisible

Browse Source 
Mention that besides change edits, using this option is also leaking
private changes.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I0180020838678dcb9d4ac3212737419c25e94305
This commit is contained in:
Edwin Kempin
2020-11-04 14:45:21 +01:00
committed by Luca Milanesio
parent 56b29e12ea
commit 3e856b2ce0
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Documentation/access-control.txt
View File

@@ -869,6 +869,11 @@ The change owner and any explicitly added reviewers can always see
private changes (even without having the `View Private Changes` access private changes (even without having the `View Private Changes` access
right assigned). right assigned).
**NOTE**: If link:config-gerrit.html#auth.skipFullRefEvaluationIfAllRefsAreVisible[
auth.skipFullRefEvaluationIfAllRefsAreVisible] is `true` (which is the case by
default) privates changes and all change edit refs are also visible to users
that have read access on `refs/*`.
[[category_toggle_work_in_progress_state]] [[category_toggle_work_in_progress_state]]
=== Toggle Work In Progress state === Toggle Work In Progress state

7
Documentation/config-gerrit.txt
View File

@@ -684,8 +684,11 @@ By default, false.
[[auth.skipFullRefEvaluationIfAllRefsAreVisible]]auth.skipFullRefEvaluationIfAllRefsAreVisible:: [[auth.skipFullRefEvaluationIfAllRefsAreVisible]]auth.skipFullRefEvaluationIfAllRefsAreVisible::
+ +
Whether to skip the full ref visibility checks as a performance shortcut when all refs are Whether to skip the full ref visibility checks as a performance shortcut when a
visible to a user. Full ref filtering would filter out things like pending edits. user has READ permission for all refs.
+
The full ref filtering would filter out refs for pending edits, private changes
and auto merge commits.
+ +
By default, true. By default, true.