opendev/gerrit
Code Issues Proposed changes

Optimizations to tiny icons

Browse Source 
* give all icons a ToolTip title
* add CSS class "link" to set cursor:pointer and use it for the icons

Change-Id: I88a43bbe64b46113d159ac9bd178d901df530708
This commit is contained in:
Steffen Gebert
2013-01-02 14:47:41 +01:00
parent 57143be354
commit 4030f6bbc4
8 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/GerritCss.java
View File

@@ -147,6 +147,7 @@ public interface GerritCss extends CssResource {
String leftMostCell();
String lineHeader();
String lineNumber();
String link();
String linkMenuBar();
String linkMenuItemNotLast();
String menuBarUserName();

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ApprovalTable.java
View File

@@ -383,6 +383,7 @@ public class ApprovalTable extends Composite {
remove.setTitle(Util.M.removeReviewer( //
FormatUtil.name(accountCache.get(ad.getAccount()))));
remove.setStyleName(Gerrit.RESOURCES.css().removeReviewer());
remove.addStyleName(Gerrit.RESOURCES.css().link());
remove.addClickHandler(new ClickHandler() {
@Override
public void onClick(ClickEvent event) {

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.java
View File

@@ -92,6 +92,7 @@ public interface ChangeConstants extends Constants {
String changeInfoBlockProject();
String changeInfoBlockBranch();
String changeInfoBlockTopic();
String changeInfoBlockTopicAlterTopicToolTip();
String changeInfoBlockUploaded();
String changeInfoBlockUpdated();
String changeInfoBlockStatus();
@@ -132,6 +133,7 @@ public interface ChangeConstants extends Constants {
String revertChangeTitle();
String headingEditCommitMessage();
String editCommitMessageToolTip();
String titleEditCommitMessage();
String buttonAbandonChangeBegin();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties
View File

@@ -69,6 +69,7 @@ changeInfoBlockOwner = Owner
changeInfoBlockProject = Project
changeInfoBlockBranch = Branch
changeInfoBlockTopic = Topic
changeInfoBlockTopicAlterTopicToolTip = Edit Topic
changeInfoBlockUploaded = Uploaded
changeInfoBlockUpdated = Updated
changeInfoBlockStatus = Status
@@ -117,6 +118,7 @@ headingRevertMessage = Revert Commit Message:
revertChangeTitle = Code Review - Revert Merged Change
headingEditCommitMessage = Commit Message
editCommitMessageToolTip = Edit Commit Message
titleEditCommitMessage = Create New Patch Set
buttonRestoreChangeBegin = Restore Change

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfoBlock.java
View File

@@ -156,6 +156,8 @@ public class ChangeInfoBlock extends Composite {
if (changeDetail.canEditTopicName()) {
final Image edit = new Image(Gerrit.RESOURCES.edit());
edit.addStyleName(Gerrit.RESOURCES.css().link());
edit.setTitle(Util.C.changeInfoBlockTopicAlterTopicToolTip());
edit.addClickHandler(new ClickHandler() {
@Override
public void onClick(final ClickEvent event) {

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/CommitMessageBlock.java
View File

@@ -123,6 +123,8 @@ public class CommitMessageBlock extends Composite {
false));
if (canEditCommitMessage) {
final Image edit = new Image(Gerrit.RESOURCES.edit());
edit.setTitle(Util.C.editCommitMessageToolTip());
edit.addStyleName(Gerrit.RESOURCES.css().link());
edit.addClickHandler(new ClickHandler() {
@Override
public void onClick(final ClickEvent event) {

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/gerrit.css
View File

@@ -106,6 +106,9 @@ a:hover {
padding: 0.2em 0.2em 0.2em 0.5em;
}
.link {
cursor: pointer;
}
/** MenuScreen **/
.menuScreenMenuBar {
@@ -957,7 +960,6 @@ a:hover {
.changeInfoTopicPanel img {
float: right;
cursor: pointer;
}
.changeInfoTopicPanel a {

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/AbstractPatchContentTable.java
View File

@@ -148,6 +148,7 @@ public abstract class AbstractPatchContentTable extends NavigationTable<Object>
// Prepare icons.
iconA = new Image(Gerrit.RESOURCES.addFileComment());
iconA.setTitle(PatchUtil.C.addFileCommentToolTip());
iconA.addStyleName(Gerrit.RESOURCES.css().link());
iconA.addClickHandler(new ClickHandler() {
@Override
public void onClick(ClickEvent event) {
@@ -156,6 +157,7 @@ public abstract class AbstractPatchContentTable extends NavigationTable<Object>
});
iconB = new Image(Gerrit.RESOURCES.addFileComment());
iconB.setTitle(PatchUtil.C.addFileCommentToolTip());
iconB.addStyleName(Gerrit.RESOURCES.css().link());
iconB.addClickHandler(new ClickHandler() {
@Override
public void onClick(ClickEvent event) {